-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Add automatic configuration import on extension startup #4848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi! I've gone ahead and implemented the items from the issue I posted. I think there is also an opportunity to introduce schema versioning and potentially schema migration scripts into RooCode. In my use case, I've encountered issues where the RooCode config updates frequently, breaking older configs. A way to introduce schema versioning and ways to keep track of the range of schema versions that are supported for a given RooCode release would help greatly. Please let me know if there's a need for this, and I would be more than glad to tackle that in this issue/MR or another one. Thanks! |
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @takakoutso, thank you for the PR!
I took a look at it and left a couple of suggestions.
Let me know what you think!
|
Hi @daniel-lxs, thank you for your review! I went ahead and made some adjustments. I would love to hear what you think. Thanks! |
|
Hey @takakoutso, It looks like your latest commit introduced unrelated changes. Can you take a look or do you want me to fix them for you? |
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @takakoutso for fixing the failing test!
Looks good to me!
|
Looks like some conflicts snuck in here |
- Add new VSCode setting 'roo-cline.autoImportConfigPath' for specifying config file path - Implement autoImportConfig utility function with path resolution and error handling - Integrate auto-import functionality into extension activation - Add comprehensive test coverage for auto-import scenarios - Support absolute paths, relative paths, and home directory expansion (~/) - Graceful error handling - extension continues to work if config import fails - User notifications for successful imports and warnings for failures
- Add auto_import_success and auto_import_failed translation keys - Translate messages into all 18 supported languages - Update autoImportSettings.ts to use i18n t() function - Ensure consistent user experience across all locales
Co-authored-by: Roo Code <[email protected]> Co-authored-by: Daniel Riccio <[email protected]>
…eInc#4848) Co-authored-by: Roo Code <[email protected]> Co-authored-by: Daniel Riccio <[email protected]>
Related GitHub Issue
Closes: #4792
Description
Test Procedure
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Refactor
autoImportConfigto consolidate provider settings, update tests, and improve error handling.providerSettingsManagerandcontextProxyintoproviderinautoImportConfig()inautoImportConfig.ts.importConfigFromPath()to useproviderfor settings management.autoImportConfig.spec.tsto reflect changes inautoImportConfig.ts.eslint-disablecomment inglobal.d.ts.activate()inextension.tsto passprovidertoautoImportConfig().This description was created by
for 19be0d2. You can customize this summary. It will automatically update as commits are pushed.