Skip to content

Conversation

@takakoutso
Copy link
Contributor

@takakoutso takakoutso commented Jun 18, 2025

Related GitHub Issue

Closes: #4792

Description

Test Procedure

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Refactor autoImportConfig to consolidate provider settings, update tests, and improve error handling.

  • Refactoring:
    • Consolidate providerSettingsManager and contextProxy into provider in autoImportConfig() in autoImportConfig.ts.
    • Update importConfigFromPath() to use provider for settings management.
  • Testing:
    • Update mocks in autoImportConfig.spec.ts to reflect changes in autoImportConfig.ts.
    • Add tests for handling invalid JSON and file system errors.
  • Misc:
    • Remove unused eslint-disable comment in global.d.ts.
    • Adjust activate() in extension.ts to pass provider to autoImportConfig().

This description was created by Ellipsis for 19be0d2. You can customize this summary. It will automatically update as commits are pushed.

@takakoutso takakoutso requested review from cte, jr and mrubens as code owners June 18, 2025 17:26
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 18, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 18, 2025
@takakoutso
Copy link
Contributor Author

Hi! I've gone ahead and implemented the items from the issue I posted. I think there is also an opportunity to introduce schema versioning and potentially schema migration scripts into RooCode. In my use case, I've encountered issues where the RooCode config updates frequently, breaking older configs. A way to introduce schema versioning and ways to keep track of the range of schema versions that are supported for a given RooCode release would help greatly. Please let me know if there's a need for this, and I would be more than glad to tackle that in this issue/MR or another one. Thanks!

@takakoutso takakoutso changed the base branch from fix-4792 to main June 18, 2025 17:53
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 18, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 18, 2025
@daniel-lxs daniel-lxs changed the title Fix 4792 feat: Add automatic configuration import on extension startup Jun 19, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @takakoutso, thank you for the PR!
I took a look at it and left a couple of suggestions.

Let me know what you think!

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Changes Requested] in Roo Code Roadmap Jun 19, 2025
@takakoutso
Copy link
Contributor Author

Hi @daniel-lxs, thank you for your review! I went ahead and made some adjustments. I would love to hear what you think. Thanks!

@daniel-lxs daniel-lxs moved this from PR [Changes Requested] to PR [Needs Prelim Review] in Roo Code Roadmap Jun 24, 2025
@daniel-lxs
Copy link
Member

Hey @takakoutso, It looks like your latest commit introduced unrelated changes.

Can you take a look or do you want me to fix them for you?

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Changes Requested] in Roo Code Roadmap Jun 24, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 24, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 24, 2025
@daniel-lxs daniel-lxs moved this from PR [Changes Requested] to PR [Needs Review] in Roo Code Roadmap Jun 25, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @takakoutso for fixing the failing test!

Looks good to me!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2025
@mrubens
Copy link
Collaborator

mrubens commented Jun 26, 2025

Looks like some conflicts snuck in here

roomote and others added 11 commits June 26, 2025 14:48
- Add new VSCode setting 'roo-cline.autoImportConfigPath' for specifying config file path
- Implement autoImportConfig utility function with path resolution and error handling
- Integrate auto-import functionality into extension activation
- Add comprehensive test coverage for auto-import scenarios
- Support absolute paths, relative paths, and home directory expansion (~/)
- Graceful error handling - extension continues to work if config import fails
- User notifications for successful imports and warnings for failures
- Add auto_import_success and auto_import_failed translation keys
- Translate messages into all 18 supported languages
- Update autoImportSettings.ts to use i18n t() function
- Ensure consistent user experience across all locales
@mrubens mrubens merged commit 562a007 into RooCodeInc:main Jun 30, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 30, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 30, 2025
hannesrudolph pushed a commit that referenced this pull request Jul 3, 2025
utarn pushed a commit to modelharbor/ModelHarbor-Agent that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

RooCode config import on extension load

5 participants