Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jun 19, 2025

Summary

This PR fixes the codebase indexing issue reported in #4869 where indexing stopped working after version 3.21.0.

Problem

The issue was in the function where the pattern in was incorrectly matching the current directory in relative paths (like ), causing ALL files to be ignored during codebase indexing.

Solution

  • Modified to explicitly skip the current directory marker
  • Added a length check to ensure the pattern only matches directories that start with and have more than one character
  • Updated version to 3.21.0

Testing

  • All existing tests pass
  • Verified the fix with manual testing showing that normal files are now correctly allowed while hidden directories are still properly ignored

Files Changed

    • Fixed the directory filtering logic
    • Updated version to 3.21.0

Closes #4869


Important

Fixes directory filtering in isPathInIgnoredDirectory() to correctly handle hidden directories and updates version to 3.21.0.

  • Behavior:
    • Fixes directory filtering in isPathInIgnoredDirectory() in ignore-utils.ts by skipping current directory marker . and ensuring .* pattern matches only directories with more than one character.
    • Updates version to 3.21.0 in package.json.
  • Testing:
    • All existing tests pass.
    • Manual testing confirms normal files are indexed, hidden directories are ignored.

This description was created by Ellipsis for c056686. You can customize this summary. It will automatically update as commits are pushed.

…tering

The issue was in the isPathInIgnoredDirectory function where the '.*' pattern
was incorrectly matching the current directory '.' in relative paths, causing
ALL files to be ignored during codebase indexing.

Changes:
- Modified isPathInIgnoredDirectory to skip the current directory marker '.'
- Added length check to ensure '.*' pattern only matches directories with actual names
- Updated version to 3.21.0

This resolves the codebase indexing regression introduced in the directory
filtering changes.
@roomote roomote requested review from cte, jr and mrubens as code owners June 19, 2025 07:32
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 19, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 19, 2025
@daniel-lxs
Copy link
Member

Closing, this is not the reason why codebase indexing stopped working

@daniel-lxs daniel-lxs closed this Jun 19, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 19, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 19, 2025
@roomote roomote deleted the fix-4869 branch June 19, 2025 15:41
@DScoNOIZ
Copy link

I have exactly the same problems, only the provider is different. Everything works fine only in version 3.20.3
The latest version at the moment also does not work properly with indexing My config which works fine with indexing in 3.20.3 Codebase Indexing is an experimental feature that creates a semantic search index of your project using AI embeddings. This allows Roo Code to better understand and navigate large codebases, finding relevant code based on meaning, not just keywords.

Indexed - File watcher started.
Embeddings provider

OpenAI Compatible
Base URL:
http://0.0.0.0:5058/v1
API Key:
••••••••••••••••••••••••••
Model
text-embedding-3-small
Embedding dimension:
768
The embedding dimension (output size) for your model. Check your provider's documentation for this value. Common values: 384, 768, 1536, 3072.

URL Qdrant
http://localhost:6333/
Qdrant Key:
•••••••••
Please save your settings before starting the indexing process.

Clear index data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Codebase Indexing - no longer works after 3.21.0

5 participants