Added Enable Roo Code quick fixes setting to disable quick fixes. #4878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
Hey @OlegOAndreev, thanks for the PR! I noticed a few inconsistencies with the translations. Several language files (Spanish, Indonesian, Japanese, Korean, Russian, Vietnamese, and Traditional Chinese) are missing trailing periods in the new Also, just a heads-up that the addition of this setting might cause existing unit tests to fail, since they expect code actions to always be provided. You might want to add a test case in The implementation looks solid overall. Nice work on addressing the issue! |
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Changes Requested]
in Roo Code Roadmap
hannesrudolph
added
PR - Changes Requested
and removed
PR - Needs Preliminary Review
labels
Collaborator
|
@daniel-lxs ran pr-fixer on this |
daniel-lxs
moved this from PR [Changes Requested]
to PR [Needs Prelim Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Preliminary Review
and removed
PR - Changes Requested
labels
- Add missing period to French translation for consistency - Add test case for disabled enableCodeActions setting - Fix existing test mock setup for proper configuration handling
daniel-lxs
approved these changes
Jun 23, 2025
Member
There was a problem hiding this comment.
Thanks @OlegOAndreev and @hannesrudolph! This looks good!
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
approved these changes
Jun 23, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
cte
pushed a commit
that referenced
this pull request
Jun 24, 2025
) * Added Enable Roo Code quick fixes setting to disable quick fixes. * Fix: Address PR review comments and failing tests for #4878 * Fix localization consistency and add test coverage - Add missing period to French translation for consistency - Add test case for disabled enableCodeActions setting - Fix existing test mock setup for proper configuration handling --------- Co-authored-by: hannesrudolph <[email protected]> Co-authored-by: RooCode <[email protected]>
Alorse
pushed a commit
to Alorse/Roo-Code
that referenced
this pull request
Jun 27, 2025
…oCodeInc#4878) * Added Enable Roo Code quick fixes setting to disable quick fixes. * Fix: Address PR review comments and failing tests for RooCodeInc#4878 * Fix localization consistency and add test coverage - Add missing period to French translation for consistency - Add test case for disabled enableCodeActions setting - Fix existing test mock setup for proper configuration handling --------- Co-authored-by: hannesrudolph <[email protected]> Co-authored-by: RooCode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #1747
Description
Added configuration for disabling Roo Code quick fixes. The configuration uses standard VSCode configuration.
Test Procedure
Disable the setting, check that quick fixes "Add to Roo Code" and others no longer appear.
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Added
enableCodeActionssetting to toggle Roo Code quick fixes, with updates toCodeActionProvider.tsand localization files.enableCodeActionssetting inpackage.jsonto toggle Roo Code quick fixes.provideCodeActions()inCodeActionProvider.tschecksenableCodeActionssetting to determine if quick fixes should be provided.package.nls.*.jsonfiles to includesettings.enableCodeActions.descriptionin multiple languages.This description was created by
for 5474bfb. You can customize this summary. It will automatically update as commits are pushed.