Fixes #4888: Fix spinner persisting in completed tasks UI #4889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed intermittent state management bug where spinners remained visible on completed task items - Updated ChatRow component to properly detect when operations have completed: - Command execution: Check for api_req_finished, completion_result, or non-partial command_output messages - MCP server requests: Check for mcp_server_response messages - API requests: Improved logic to properly detect finished/cancelled/failed states - Added modifiedMessages prop to ChatRow and BrowserSessionRow components for completion detection - Added comprehensive test suite for spinner logic scenarios - Ensures spinners are cleared when read/edit activities complete as expected
dosubot
bot
added
size:L
Contributor
|
Generated with ❤️ by ellipsis.dev |
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
The solution on this PR seems to be fragile since it's checking the messages types to see if the task is completed, it seems that the actual issue is related to the cost of the last message being undefined. I'm preparing a PR to fix this issue properly. |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the intermittent state management bug where spinners remained visible on completed task items in the task history/activity panel.
Problem
The issue was in the ChatRow component's spinner logic. The conditions for showing spinners (, , and API request states) didn't properly detect when operations had completed, causing spinners to persist even after tasks finished.
Solution
Key Changes:
Enhanced Command Execution Detection: Updated to check for completion indicators:
Improved MCP Server Response Detection: Updated to check for messages that indicate completion.
Better API Request State Management: Refactored the API request spinner logic to properly detect finished, cancelled, and failed states.
Added Prop: Extended ChatRow and BrowserSessionRow components to receive the full message array for completion detection.
Comprehensive Test Coverage: Added test suite covering all spinner scenarios to prevent regressions.
Testing
Fixes
Closes #4888
Type of Change