Fixes #4900: MCP Tool reminders enforce the wrong syntax #4901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified formatResponse.noToolsUsed() and formatResponse.missingToolParameterError() to accept optional hasMcpTools parameter - Added getToolUseInstructionsReminder() function that provides correct syntax based on tool type - When MCP tools are available, shows proper use_mcp_tool format instead of generic XML format - Added hasMcpToolsAvailable() method to Task class to detect when MCP servers with tools are connected - Updated all call sites to pass MCP tool availability information - Maintains backward compatibility with legacy toolUseInstructionsReminder constant This prevents the infinite loop where AI tries wrong MCP syntax and gets corrected with wrong format.
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
This PR would cause Roo Code to return instructions on how to use MCP tools when the model fails to use any tool, not just MCP tools. Since it's difficult to determine intent, we can't tell what tool the LLM is trying to use. If we assume that the model is trying to use MCP tools when it doesn't use any tool correctly, we might end up confusing the model even more. A better solution for this issue might involve normalizing our MCP tool call schema to use XML or adding a reminder to the "No tools used" message specifically for MCP tools, though that might also confuse the model. Closing for now. |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the infinite loop where AI tries wrong MCP syntax and gets corrected with wrong format.
Important
Fixes incorrect MCP tool syntax reminders by introducing a new function to provide correct instructions based on tool availability.
formatResponse.noToolsUsed()andformatResponse.missingToolParameterError()now accepthasMcpToolsparameter to determine tool syntax.getToolUseInstructionsReminder()to provide correct syntax based on tool type.use_mcp_toolformat when MCP tools are available, otherwise defaults to XML format.hasMcpToolsAvailable()method to check MCP tool availability.toolUseInstructionsReminderconstant.This description was created by
for ba0d081. You can customize this summary. It will automatically update as commits are pushed.