Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jan 22, 2025

#483


Important

Fixes role definition override bug in generatePrompt by prioritizing promptComponent roleDefinition and adds relevant tests.

  • Behavior:
    • Fixes bug in generatePrompt in system.ts to prioritize promptComponent roleDefinition over modeConfig roleDefinition.
    • Adds fallback to modeConfig roleDefinition if promptComponent roleDefinition is unavailable.
  • Tests:
    • Adds test should use promptComponent roleDefinition when available in system.test.ts.
    • Adds test should fallback to modeConfig roleDefinition when promptComponent has no roleDefinition in system.test.ts.

This description was created by Ellipsis for 8e48b73. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

🦋 Changeset detected

Latest commit: 8e48b73

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrubens mrubens merged commit d479d84 into main Jan 22, 2025
6 checks passed
@mrubens mrubens deleted the fix_built_in_role_definition_overrides branch January 22, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants