Skip to content

Conversation

@jr
Copy link
Collaborator

@jr jr commented Jun 20, 2025

Keep clerk-auth-credentials for production, but scope with the clerk url if overridden to prevent clobbering.


Important

Scopes clerk-auth-credentials by Clerk base URL in AuthService to prevent credential clobbering across environments.

  • Behavior:
    • AuthService now scopes clerk-auth-credentials by Clerk base URL, using clerk-auth-credentials-<url> for non-production URLs.
    • Updates storeCredentials, loadCredentials, and clearCredentials methods to use scoped keys.
    • Modifies event listener in initialize to respond to changes in scoped keys.
  • Tests:
    • Adds tests in AuthService.spec.ts to verify behavior with production and custom Clerk URLs.
    • Tests ensure credentials are stored, loaded, and cleared using the correct scoped keys.
    • Verifies event listener only responds to changes in the correct scoped key.

This description was created by Ellipsis for 9073ac2. You can customize this summary. It will automatically update as commits are pushed.

@jr jr requested review from cte and mrubens as code owners June 20, 2025 05:24
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 20, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 20, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 20, 2025
@jr jr merged commit b31250d into main Jun 20, 2025
25 checks passed
@jr jr deleted the jr/scope-dev-rcc-credentials branch June 20, 2025 05:34
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 20, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 20, 2025
cte pushed a commit that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants