Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jun 20, 2025

Summary

This PR fixes a failing test in the MarketplaceViewStateManager test suite.

Problem

The test "should initialize with default state" was expecting isFetching to be false, but the implementation correctly initializes it as true to show a loading state on initial load.

Solution

Updated the test expectation to match the actual behavior of the implementation, changing the expected value from false to true.

Changes

  • Modified webview-ui/src/components/marketplace/__tests__/MarketplaceViewStateManager.spec.ts to expect isFetching: true in the default state

Testing

  • ✅ The test now passes correctly
  • ✅ No changes were made to the implementation logic
  • ✅ All type checks pass
  • ✅ All linting passes

Important

Fixes test in MarketplaceViewStateManager.spec.ts to expect isFetching: true in default state.

  • Test Fix:
    • Update MarketplaceViewStateManager.spec.ts to expect isFetching: true in the default state.
  • Testing:
    • Test now passes correctly.
    • No changes to implementation logic.
    • All type checks and linting pass.

This description was created by Ellipsis for a67d4dd. You can customize this summary. It will automatically update as commits are pushed.

…ing state

The test was expecting isFetching to be false in the default state, but the implementation correctly initializes it as true to show a loading state on initial load. Updated the test expectation to match the actual behavior.
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners June 20, 2025 20:02
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 20, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 20, 2025
@jr jr merged commit 9da598c into main Jun 20, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 20, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 20, 2025
@jr jr deleted the fix/marketplace-view-state-manager-test branch June 20, 2025 20:36
cte pushed a commit that referenced this pull request Jun 24, 2025
…ing state (#4954)

The test was expecting isFetching to be false in the default state, but the implementation correctly initializes it as true to show a loading state on initial load. Updated the test expectation to match the actual behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants