Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jun 20, 2025

Fixes #4958

Problem

The ShadowCheckpointService.spec.ts tests were timing out on Windows CI due to the default 10-second vitest timeout being insufficient. The tests involve heavy file system and git operations that can take longer than 10 seconds, especially on Windows CI environments.

Solution

  • Added testTimeout: 20_000 and hookTimeout: 20_000 to the vitest configuration in src/vitest.config.ts
  • Removed the redundant vitest.setConfig({ testTimeout: 10_000 }) call from the test file since timeout is now properly configured globally
  • The hookTimeout configuration is crucial as the failure was specifically in the beforeEach hook

Testing

  • All 30 tests in ShadowCheckpointService.spec.ts now pass locally in ~19 seconds
  • The longest individual test takes ~882ms, well within the new 20-second timeout
  • Type checking and linting pass successfully

This should resolve the Windows CI timeout issues while maintaining test reliability.


Important

Increase vitest timeout settings to 20 seconds in vitest.config.ts to fix Windows CI test timeouts.

  • Configuration:
    • Increased testTimeout and hookTimeout to 20_000 in vitest.config.ts to address Windows CI timeouts.
    • Removed vitest.setConfig({ testTimeout: 10_000 }) from ShadowCheckpointService.spec.ts as global configuration now handles timeouts.
  • Testing:
    • All tests in ShadowCheckpointService.spec.ts pass locally within the new timeout limits.
    • Type checking and linting pass successfully.

This description was created by Ellipsis for e605f5b. You can customize this summary. It will automatically update as commits are pushed.

- Add testTimeout and hookTimeout of 20 seconds to vitest.config.ts
- Remove redundant vitest.setConfig() call from test file
- Fixes timeout issues in ShadowCheckpointService.spec.ts on Windows CI
@roomote roomote requested review from cte, jr and mrubens as code owners June 20, 2025 23:26
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 20, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 20, 2025
@cte cte merged commit 133af6a into main Jun 21, 2025
15 checks passed
@cte cte deleted the fix-4958 branch June 21, 2025 00:14
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 21, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 21, 2025
cte added a commit that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

ShadowCheckpointService.spec.ts is timing out

4 participants