Fixes #4956: Add proper Jupyter notebook support for apply_diff and write_to_file tools #4960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
roomote
commented
Jun 20, 2025
roomote
commented
- Created jupyter-notebook-handler.ts with utilities for parsing and handling .ipynb files
- Modified applyDiffTool.ts to extract cell content for editing and reconstruct notebook JSON
- Modified multiApplyDiffTool.ts to handle Jupyter notebooks in batch operations
- Modified writeToFileTool.ts to detect and properly handle notebook content vs raw JSON
- Added comprehensive test suite for all notebook operations
- Prevents notebook corruption by maintaining proper JSON structure
- Supports both extracted content editing and direct JSON editing workflows
…rite_to_file tools - Created jupyter-notebook-handler.ts with utilities for parsing and handling .ipynb files - Modified applyDiffTool.ts to extract cell content for editing and reconstruct notebook JSON - Modified multiApplyDiffTool.ts to handle Jupyter notebooks in batch operations - Modified writeToFileTool.ts to detect and properly handle notebook content vs raw JSON - Added comprehensive test suite for all notebook operations - Prevents notebook corruption by maintaining proper JSON structure - Supports both extracted content editing and direct JSON editing workflows
dosubot
bot
added
size:XL
Contributor
|
Generated with ❤️ by ellipsis.dev |
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
Closing for now since we still don't have enough info to go for, this seems to be trying to address the symptoms rather than the cause. It is probable that the actual problem lies in the tools formatting or model limitations/hallucinations. |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.