Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jun 20, 2025

Description

This PR introduces a new "PR Fixer" mode to help developers resolve issues in existing pull requests more efficiently.

Changes Made

  • Added new PR Fixer mode definition in .roomodes with:

    • Role definition for a pull request resolution specialist
    • Appropriate tool group permissions (read, edit, command, mcp)
    • Custom instructions for handling merge conflict markers in diffs
  • Created comprehensive rule files in .roo/rules-pr-fixer/:

    • 1_workflow.xml: Defines the workflow for analyzing and fixing PRs
    • 2_best_practices.xml: Best practices for PR resolution
    • 3_common_patterns.xml: Common patterns and approaches
    • 4_tool_usage.xml: Guidelines for using tools effectively
    • 5_examples.xml: Examples of PR fixing scenarios

Features

The PR Fixer mode helps with:

  • Analyzing PR review comments to understand required changes
  • Checking CI/CD workflow statuses to identify failing tests
  • Fetching and analyzing test logs to diagnose failures
  • Identifying and resolving merge conflicts
  • Guiding users through the resolution process

Testing

  • Mode definition follows existing patterns
  • XML rule files are well-structured and valid
  • All linting checks pass
  • Type checking passes

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic
  • No breaking changes

Important

Introduces pr-fixer mode to resolve pull request issues with workflows, best practices, and tool guidance.

  • Behavior:
    • Adds pr-fixer mode in .roomodes for resolving pull request issues.
    • Mode focuses on analyzing PR comments, checking CI/CD statuses, resolving merge conflicts, and guiding users.
  • Rules and Workflows:
    • Adds 1_workflow.xml in .roo/rules-pr-fixer/ for PR analysis and resolution workflow.
    • Adds 2_best_practices.xml for context gathering and incremental fixes.
    • Adds 3_common_patterns.xml for PR status checking and conflict resolution.
    • Adds 4_tool_usage.xml for tool priorities and specific guidance.
    • Adds 5_examples.xml with scenarios for fixing failing tests and addressing comments.
  • Permissions:
    • Grants read, edit, command, and mcp permissions to pr-fixer mode.

This description was created by Ellipsis for 19e6daa. You can customize this summary. It will automatically update as commits are pushed.

- Add new PR Fixer mode to help address feedback and resolve issues in existing PRs
- Include workflow instructions for analyzing PR comments, failing tests, and merge conflicts
- Add best practices and common patterns for PR resolution
- Include tool usage guidelines and examples
- Add custom instructions for handling merge conflict markers in diffs
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners June 20, 2025 23:52
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 20, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 21, 2025
@mrubens mrubens merged commit ef19082 into main Jun 21, 2025
8 checks passed
@mrubens mrubens deleted the feat/add-pr-fixer-mode branch June 21, 2025 16:11
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 21, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 21, 2025
cte pushed a commit that referenced this pull request Jun 24, 2025
* feat: add PR Fixer mode for resolving pull request issues

- Add new PR Fixer mode to help address feedback and resolve issues in existing PRs
- Include workflow instructions for analyzing PR comments, failing tests, and merge conflicts
- Add best practices and common patterns for PR resolution
- Include tool usage guidelines and examples
- Add custom instructions for handling merge conflict markers in diffs

* refactor: remove duplicate custom instructions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants