Fix flakey ModelPicker test

[cte]

From Roo Code:

I successfully fixed the flaky ModelPicker.spec.tsx test by addressing timeout management issues that were causing "timeout after test environment was torn down" errors.

Changes Made:

1. Component Changes (ModelPicker.tsx):

• Added timeout refs: selectTimeoutRef and closeTimeoutRef to track setTimeout calls
• Enhanced onSelect: Now clears existing timeouts before setting new ones
• Enhanced onOpenChange: Now clears existing timeouts before setting new ones
• Added cleanup useEffect: Ensures all timeouts are cleared when component unmounts

2. Test Changes (ModelPicker.spec.tsx):

• Added fake timers: Using vi.useFakeTimers() in beforeEach
• Added proper cleanup: Using vi.clearAllTimers() and vi.useRealTimers() in afterEach
• Replaced async timeouts: Changed from setTimeout promises to vi.advanceTimersByTime(100) for deterministic timing
• Added timer advancement: After model selections to ensure timeouts are processed

Root Cause:

The original issue was that setTimeout calls in the ModelPicker component were creating timers that outlived the test environment, causing them to fire after test cleanup and resulting in the "timeout after test environment was torn down" error.

Result:

The tests now run consistently and are no longer flaky. The timeout management ensures proper cleanup both at the component level and test level, preventing resource leaks and timing-related test failures.

---

Important

Fixes flaky ModelPicker test by improving timeout management in component and tests.

• Component Changes in ModelPicker.tsx:
  • Added selectTimeoutRef and closeTimeoutRef to track setTimeout calls.
  • Enhanced onSelect and onOpenChange to clear existing timeouts before setting new ones.
  • Added useEffect for cleanup of timeouts on component unmount.
• Test Changes in ModelPicker.spec.tsx:
  • Added vi.useFakeTimers() in beforeEach and vi.clearAllTimers() in afterEach.
  • Replaced setTimeout promises with vi.advanceTimersByTime(100) for deterministic timing.
  • Added timer advancement after model selections to ensure timeouts are processed.

^{This description was created by for 753c959. You can customize this summary. It will automatically update as commits are pushed.}