Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jun 21, 2025

Description

Fixes #4993

This PR addresses two issues with the MCP tool eye icon:

  1. The eye icon was showing the wrong state (showed eye when enabled, should show eye-closed)
  2. The eye icon was appearing in chat context where it shouldn't be visible

Changes Made

Testing

  • All existing tests pass
  • Added tests for the new isInChatContext prop
  • Added tests to verify eye button is hidden in chat context
  • Added tests to verify correct icon state based on enabledForPrompt
  • Manual testing completed:
    • Eye icon no longer appears in chat when MCP tools are executed
    • Eye icon shows correct state in settings (eye-closed when enabled)

Verification of Acceptance Criteria

  • In chat session: McpToolRow appears without the eye toggle button when Roo requests to use an MCP tool
  • In MCP settings page: Eye toggle button is visible and functional
  • Eye icon correctly toggles between eye and eye-closed based on enabledForPrompt state

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic
  • Documentation updated (if needed)
  • No breaking changes
  • Accessibility checked (keyboard navigation works)

Screenshots/Demo

image

@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners June 21, 2025 19:17
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working UI/UX UI/UX related or focused labels Jun 21, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 21, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 21, 2025
@mrubens mrubens merged commit 5b9907b into main Jun 21, 2025
23 of 24 checks passed
@mrubens mrubens deleted the fix/issue-4993-mcp-tool-eye-icon branch June 21, 2025 19:22
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 21, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

MCP tool eye icon shows wrong state and shouldn't appear in chat context

3 participants