fix(qdrant): add URL prefix handling for QdrantClient initialization

[CW-B-W]

Related GitHub Issue

Closes: #5032

Potentially (along with #4992) Resolves: #4092

Description

This PR fixes a bug in the QdrantVectorStore constructor where the QdrantClient was not correctly configured to handle URLs with path prefixes. Previously, the prefix parameter was not being extracted from the URL's pathname, leading to connection issues for certain Qdrant deployments.

The fix involves:

• Modifying the QdrantClient instantiation in src/services/code-index/vector-store/qdrant-client.ts to extract the pathname from the parsed URL and pass it as the prefix option to the QdrantClient constructor, but only if the pathname is not the root (/).

Test Procedure

Manual Verification (Realistic Scenarios):
I have tested with the following type of URLs:

• https://example.com/qdrant
• https://example.com
• https://example.com:6333
• http://example.com
• http://example.com:6333

Unit Tests (Mocked Environment):
New unit test cases have been added to src/services/code-index/vector-store/__tests__/qdrant-client.spec.ts under a new "URL Prefix Handling" describe block. These tests verify:

• That the prefix is correctly passed to QdrantClient when the URL has a non-root pathname (e.g., http://localhost:6333/some/path).
• That the prefix is undefined when the URL has a root pathname (e.g., http://localhost:6333/).
• That HTTPS URLs with paths also correctly set the prefix.

To run the unit tests:

1. Navigate to the src/ directory: cd src/
2. Execute the test command: npm test
   All unit tests, including the newly added ones, should pass.

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Testing: New and/or updated tests have been added to cover my changes (if applicable).
• Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A (Backend logic change)

Documentation Updates

• No documentation updates are required.

Additional Notes

None.

Get in Touch

---

Important

Fixes URL prefix handling in QdrantVectorStore by correctly setting prefix in QdrantClient initialization.

• Behavior:
  • Fixes URL prefix handling in QdrantVectorStore constructor in qdrant-client.ts by extracting pathname from URL and passing it as prefix to QdrantClient if not root.
• Tests:
  • Adds tests in qdrant-client.spec.ts to verify prefix is set correctly for non-root path URLs and is undefined for root path URLs.
  • Tests HTTPS URLs with paths to ensure correct prefix setting.

^{This description was created by for 9b09f08. You can customize this summary. It will automatically update as commits are pushed.}

[daniel-lxs]

Thanks for this fix! The implementation looks good. I've left a few suggestions for edge cases and error handling that might be worth considering.

[daniel-lxs]

I noticed that URLs with trailing slashes aren't normalized. Would http://localhost:6333/api/ and http://localhost:6333/api result in different prefix values (/api/ vs /api)? If so, should we consider normalizing the pathname to ensure consistent behavior?

For example:

prefix: urlObj.pathname === "/" ? undefined : urlObj.pathname.replace(/\/$/, '')

[CW-B-W]

Appreciate for you suggestion, I apprently ignored that.
I have revised it and committed.

[daniel-lxs]

Thank you for addressing the suggestions, I tested it and it works!

[hannesrudolph]

@CW-B-W If you have discord would you be able to message me (hrudolph)?