Skip e2e test that often prompts you #5044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jr
approved these changes
Jun 23, 2025
Member
|
I can probably take a look to see exactly why it's asking this question and fix it. But you can skip it for now. |
mrubens
approved these changes
Jun 23, 2025
Collaborator
mrubens
left a comment
mrubens
left a comment
There was a problem hiding this comment.
Skipping sounds good to stop the flakes. Probably worth looking at whether there's a legit issue, or more likely, a timing issue behind this failure. @daniel-lxs do you have any ideas?
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| }) | ||
|
|
||
| test("Should validate MCP request message format and complete successfully", async function () { | ||
| test.skip("Should validate MCP request message format and complete successfully", async function () { |
Contributor
There was a problem hiding this comment.
The test has been changed to skip (using test.skip) to avoid interactive prompts that can cause CI failures. It would be helpful to add an inline comment explaining the reason for skipping this test, so future maintainers understand the context and can revisit it later if needed.
Suggested change
| test.skip("Should validate MCP request message format and complete successfully", async function () { | |
| test.skip("Should validate MCP request message format and complete successfully", async function () { // Skipped to avoid interactive prompts that can cause CI failures. See PR for context. |
dosubot
bot
added
size:XS
Member
Member
|
This should help #5046 |
hannesrudolph
added
the
Issue/PR - Triage
cte
added a commit
that referenced
this pull request
Jun 24, 2025
Alorse
pushed a commit
to Alorse/Roo-Code
that referenced
this pull request
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm seeing this locally, which I think is causing the CI failures:
Important
Skip test in
use-mcp-tool.test.tsthat causes CI failures due to frequent prompts."Should validate MCP request message format and complete successfully"inuse-mcp-tool.test.tsdue to frequent prompts causing CI failures.This description was created by
for 15cca80. You can customize this summary. It will automatically update as commits are pushed.