Skip to content

Fix TemperatureControl test flake #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Fix TemperatureControl test flake #5045

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions webview-ui/src/components/settings/__tests__/TemperatureControl.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// npx vitest src/components/settings/__tests__/TemperatureControl.spec.tsx

import { render, screen, fireEvent } from "@testing-library/react"
import { render, screen, fireEvent, waitFor } from "@testing-library/react"

import { TemperatureControl } from "../TemperatureControl"

Expand Down Expand Up @@ -64,16 +64,18 @@ describe("TemperatureControl", () => {
// Uncheck - should clear temperature.
fireEvent.click(checkbox)

// Waiting for debounce.
await new Promise((x) => setTimeout(x, 100))
expect(onChange).toHaveBeenCalledWith(null)
// Wait for debounced onChange call.
await waitFor(() => {
expect(onChange).toHaveBeenCalledWith(null)
})

// Check - should restore previous temperature.
fireEvent.click(checkbox)

// Waiting for debounce.
await new Promise((x) => setTimeout(x, 100))
expect(onChange).toHaveBeenCalledWith(0.7)
// Wait for debounced onChange call.
await waitFor(() => {
expect(onChange).toHaveBeenCalledWith(0.7)
})
})

it("syncs checkbox state when value prop changes", () => {
Expand Down
Loading