Fetch settings only when ready #5052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 problems working together:
attempting-sessioninstead ofactive-session.RefreshTimer, so we wait 30s instead of 1s (with backoff) to fetch after a failure.Important
Fixes timing and error handling for fetching organization settings in
SettingsService.ts.SettingsServiceto startRefreshTimeronactive-sessioninstead ofattempting-session.fetchSettings()to return a boolean indicating success or failure, affecting backoff logic inRefreshTimer.fetchSettings()returnsfalseon failure to fetch or parse settings, improving retry logic.attempting-sessionevent listener inSettingsService.This description was created by
for c7dafc6. You can customize this summary. It will automatically update as commits are pushed.