feat: Deploy updated prompt generation code #5070
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the pre-flight syntax checker for all commands executed by Roo in a PowerShell environment, as specified in BRIEF_001_Roo_Syntax_Checker. This adds a validation step that writes the command to a temporary file, checks for diagnostics from the PowerShell extension, and blocks execution if any errors are found, returning the error to the user. This addresses the systemic flaw of Roo repeatedly using incorrect syntax.
This commit fixes a TypeScript error in the new PowerShell syntax validation logic. The original implementation used a .catch() on a Thenable, which is not supported. This has been replaced with a standard ry...catch block to correctly handle potential errors during temporary file deletion.
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Hey @nzshock, thank you for your contribution! We’ve recently adopted a clearer issue-first workflow to help us better understand and review pull requests. The idea is to use the linked issue to verify whether a fix is appropriate and to reproduce the original problem to confirm that it’s resolved. I recommend creating an issue and associating it with this PR so we can properly review it. I’ll temporarily close this PR for now, but feel free to reach out if you have any questions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deploys the updated prompt generation code with the new CRITICAL_RULES section.
Important
Introduces critical shell command syntax rules and PowerShell syntax validation in
TerminalProcessto ensure command compatibility and error handling.CRITICAL_RULESsection inrules.tsfor shell command syntax, requiring semicolons for PowerShell commands.validatePowerShellSyntax()inTerminalProcess.tsto check PowerShell command syntax before execution.This description was created by
for 2b95b39. You can customize this summary. It will automatically update as commits are pushed.