Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Jun 24, 2025

Description

Adds step 11 "Monitor PR Checks" to the issue-fixer workflow to automatically monitor CI/CD checks after PR creation.

Changes Made

  • Added new step 11 to .roo/rules-issue-fixer/1_Workflow.xml
  • Uses gh pr checks --watch to monitor checks in real-time
  • Provides interactive prompts for handling failed checks
  • Offers to fix failing checks if requested by user
  • Ensures PRs meet quality standards before review

Benefits

  • Early detection: Catches CI/CD failures immediately after PR creation
  • Quality assurance: Ensures PRs meet all automated checks before review
  • Time savings: Prevents reviewers from seeing PRs with failing checks
  • Better success rate: Improves likelihood of PRs being merged successfully
  • Interactive workflow: Gives users options for handling failures

How it works

  1. After PR creation (step 10), automatically run gh pr checks --watch
  2. Monitor all configured checks (tests, linting, builds, etc.) in real-time
  3. Display status updates as checks complete
  4. If checks fail, prompt user with options:
    • Fix the failures automatically
    • Show detailed error logs
    • Handle manually
    • Accept expected failures
  5. If user requests fixes, make changes and re-monitor checks

Testing

  • Validated XML syntax is correct
  • Confirmed step numbering is sequential
  • Verified instructions follow existing workflow patterns
  • Checked that all required elements are present

Checklist

  • Changes follow existing workflow structure and style
  • Step instructions are clear and actionable
  • Interactive prompts provide appropriate options
  • Documentation is comprehensive
  • No breaking changes to existing workflow
  • Maintains consistency with other workflow steps

Important

Adds step to monitor PR checks in real-time post-creation, ensuring quality before review.

  • Behavior:
    • Adds step 11 "Monitor PR Checks" to .roo/rules-issue-fixer/1_Workflow.xml to monitor CI/CD checks post-PR creation.
    • Uses gh pr checks --watch for real-time monitoring and updates.
    • Provides interactive prompts for handling failed checks, including options to fix, view logs, or handle manually.
  • Benefits:
    • Ensures PRs meet quality standards before review by catching failures early.
    • Saves reviewer time by preventing exposure to failing PRs.
    • Improves PR success rate by addressing issues promptly.
  • Testing:
    • Validated XML syntax and step numbering.
    • Confirmed instructions align with existing workflow patterns.

This description was created by Ellipsis for ef781b9. You can customize this summary. It will automatically update as commits are pushed.

- Add step 11 'Monitor PR Checks' to issue-fixer workflow
- Run 'gh pr checks --watch' after PR creation
- Monitor CI/CD checks in real-time
- Provide options to fix failing checks
- Ensure PRs meet quality standards before review
Copilot AI review requested due to automatic review settings June 24, 2025 18:37
@hannesrudolph hannesrudolph requested review from cte, jr and mrubens as code owners June 24, 2025 18:37
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jun 24, 2025
@hannesrudolph hannesrudolph moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 24, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jun 24, 2025

No security or compliance issues detected. Reviewed everything up to ef781b9.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► 1_Workflow.xml
    Add "Monitor PR Checks" step to issue-fixer workflow
    Implement PR check monitoring and failure handling

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds an interactive “Monitor PR Checks” step (step 11) to the issue-fixer workflow to stream and handle CI/CD check results immediately after PR creation.

  • Introduces gh pr checks --watch to display live check statuses.
  • Prompts users to review failures and optionally apply automated fixes.
  • Ensures PRs meet quality gates before review.
Comments suppressed due to low confidence (1)

.roo/rules-issue-fixer/1_Workflow.xml:500

  • Specify the minimum required version of GitHub CLI needed for gh pr checks --watch (e.g., GitHub CLI v2.42 or later) so users know if they need to upgrade before running this step.
      <execute_command>

@hannesrudolph
Copy link
Collaborator Author

@mrubens LGTM! ;)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 24, 2025
@mrubens mrubens merged commit f5d4847 into main Jun 24, 2025
23 checks passed
@mrubens mrubens deleted the feat/issue-fixer-pr-checks branch June 24, 2025 19:00
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 24, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 24, 2025
Alorse pushed a commit to Alorse/Roo-Code that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants