Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jun 24, 2025

This reverts commit ac85aa6 from PR #5076.

Changes Reverted

  • Removed fetchModel() method from LmStudioHandler
  • Removed models property and dynamic model fetching functionality
  • Reverted getModel() method to return static defaults
  • Removed tests for fetchModel() functionality
  • Removed import of getLMStudioModels

Files Changed

  • src/api/providers/lm-studio.ts - Reverted to original implementation
  • src/api/providers/__tests__/lmstudio.spec.ts - Removed new tests and mocks

Testing

  • ✅ All existing tests pass (8 tests passed)
  • ✅ Type checking passes
  • ✅ Linting passes

This revert restores the LM Studio handler to its previous stable state.


Important

Reverts dynamic model fetching in LmStudioHandler, restoring static defaults and removing related tests.

  • Behavior:
    • Reverts LmStudioHandler to use static model defaults in getModel().
    • Removes fetchModel() method and dynamic model fetching.
    • Deletes tests related to fetchModel() in lmstudio.spec.ts.
  • Files:
    • lm-studio.ts: Removes fetchModel() and related imports.
    • lmstudio.spec.ts: Removes tests and mocks for fetchModel().
  • Testing:
    • All existing tests pass.
    • Type checking and linting pass.

This description was created by Ellipsis for d965a24. You can customize this summary. It will automatically update as commits are pushed.

This reverts commit ac85aa6.

- Removed fetchModel() method from LmStudioHandler
- Removed models property and dynamic model fetching
- Reverted getModel() to return static defaults
- Removed tests for fetchModel() functionality
- Removed import of getLMStudioModels
@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners June 24, 2025 19:22
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 24, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jun 24, 2025

No security or compliance issues detected. Reviewed everything up to d965a24.

Security Overview
  • 🔎 Scanned files: 2 changed file(s)
Detected Code Changes
Change Type Relevant files
Refactor ► lmstudio.spec.ts
    Remove LM Studio model fetching tests
► lm-studio.ts
    Remove model fetching functionality
    Simplify getModel() implementation

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@daniel-lxs daniel-lxs changed the title Revert "fix: resolve LM Studio context length detection (#5075)" Revert fix: resolve LM Studio context length detection (#5075) Jun 24, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 24, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 24, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 24, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 24, 2025
@mrubens mrubens merged commit f666cb3 into main Jun 24, 2025
22 of 25 checks passed
@mrubens mrubens deleted the revert-5076-lmstudio-context-length branch June 24, 2025 19:56
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 24, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 24, 2025
Alorse pushed a commit to Alorse/Roo-Code that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants