Skip to content

Conversation

@qdaxb
Copy link
Contributor

@qdaxb qdaxb commented Jun 25, 2025

Related GitHub Issue

Closes: #5106

Description

Currently, when assembling the mcp prompt, command will be added after the mcp name, but there is no command for http sse mcp, so undefined will eventually appear in the prompt.

{
  "mcpServers": {
    "figma-dev-mode": {
      "type": "sse",
      "url": "http://127.0.0.1:3845/sse"
    }
  }
}
...system prompt...
# Connected MCP Servers

## figma-dev-mode (`undefined`)

### Available Tools
...

This PR adds the case of missing command field. When using http sse mcp, this part of the content will not added

Test Procedure

Pre-Submission Checklist

  • [x ] Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • [ x] Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • [x ] Self-Review: I have performed a thorough self-review of my code.
  • [ x] Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • [ x] Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • [ x] Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

20250625134953

Documentation Updates

Additional Notes

Get in Touch


Important

Fixes undefined command in MCP prompt for HTTP SSE MCP servers by checking if command exists before appending.

  • Behavior:
    • Fixes undefined command in MCP prompt for HTTP SSE MCP servers in getMcpServersSection() in mcp-servers.ts.
    • Checks if config.command exists before appending to server name.
  • Misc:
    • No changes to tests or documentation required.

This description was created by Ellipsis for 02c59a9. You can customize this summary. It will automatically update as commits are pushed.

@qdaxb qdaxb requested review from cte, jr and mrubens as code owners June 25, 2025 05:57
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 25, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 25, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 25, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 25, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 26, 2025
@mrubens mrubens merged commit 5c9b476 into RooCodeInc:main Jun 26, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 26, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 26, 2025
@qdaxb qdaxb deleted the fix_undefined_mcp branch July 2, 2025 14:23
hannesrudolph pushed a commit that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

http sse mcp will insert "undefined" in the prompt

4 participants