Fix/issue 5075 lmstudio context length #5122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add fetchModel() method to LmStudioHandler to dynamically fetch model info - Update getModel() to return actual context length instead of default value of 1 - Add comprehensive tests for new functionality with proper error handling - Maintain backward compatibility with graceful fallback to defaults Fixes RooCodeInc#5075
…nc#5075) - Updated LmStudioHandler.fetchModel() to use getModels() from model cache - Removed custom getModelWithFetch() method for consistency with other providers - Updated createMessage() and completePrompt() to use await this.fetchModel() - Fixed tests to mock getModels instead of getLMStudioModels - Ensures LM Studio models show correct context length instead of default value Fixes RooCodeInc#5075
…ub.com/RooCodeInc/Roo-Code into fix/issue-5075-lmstudio-context-length
dosubot
bot
added
size:XS
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Author
|
In retrospect, I think this is based on the wrong branch - so, if the commit in question can be cherrypicked on it's lonesome it's fine, but otherwise it needs to be redone based on the main branch, instead of the LM Studio fix one. |
daniel-lxs
changed the base branch from
fix/issue-5075-lmstudio-context-length
to
main
dosubot
bot
added
size:L
Member
|
I think this needs to be cleaned up, as you mentioned there are other unrelated changes from another PR. I'll move this back to draft, let me know if you have any questions. |
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Draft / In Progress]
in Roo Code Roadmap
hannesrudolph
added
PR - Draft / In Progress
and removed
PR - Needs Preliminary Review
labels
Collaborator
|
stale |
github-project-automation
bot
moved this from PR [Draft / In Progress]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #5121
Description
This PR makes Roo use the default info for an LM Studio model, and changes that default info to be slightly more sensible, with a context window of 50K, not 200k.
Test Procedure
Try to use a model through LM Studio when Roo cannot get it's model info.
Pre-Submission Checklist
Documentation Updates
[X] No documentation updates are required.
Get in Touch
Username is Angle on the Discord.
Important
Reduces
contextWindowfor LM Studio models from 200,000 to 50,000 and updates model selection logic to use this default when specific info is unavailable.contextWindowinlMStudioDefaultModelInfofrom 200,000 to 50,000 inlm-studio.ts.getSelectedModel()inuseSelectedModel.tsto uselMStudioDefaultModelInfowhen LM Studio model info is unavailable.This description was created by
for f8a661d. You can customize this summary. It will automatically update as commits are pushed.