Skip to content

feat(tools): add image support to read_file tool #5172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jul 29, 2025
Merged

feat(tools): add image support to read_file tool #5172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
05b2e27
feat(tools): add image support to read_file tool
samhvw8 Jun 26, 2025
7f47b14
feat: add support for AVIF image format in readFileTool
samhvw8 Jul 1, 2025
323276d
feat: add image size limit check in readFileTool
samhvw8 Jul 1, 2025
0b39158
test: enhance image support tests for path normalization
samhvw8 Jul 1, 2025
6badb51
fix pr comment
samhvw8 Jul 1, 2025
28e0b28
add setting ui for max image file size
samhvw8 Jul 3, 2025
c165fa4
handle model don support image
samhvw8 Jul 5, 2025
822a84f
add i18n
samhvw8 Jul 6, 2025
7ec9ae6
add max memory for total file
samhvw8 Jul 6, 2025
ba397ce
refactor: consolidate MIME type mapping for image formats
samhvw8 Jul 19, 2025
802fa5d
fix: re-check model image support before including images in the result
samhvw8 Jul 19, 2025
ebca4ba
fix test
samhvw8 Jul 21, 2025
af05c5c
refactor: move image processing helpers to separate file
daniel-lxs Jul 22, 2025
d018c30
Update src/core/tools/readFileTool.ts
samhvw8 Jul 23, 2025
1dc79ce
test: enhance image memory limit checks and add new test for skipping…
samhvw8 Jul 25, 2025
0fbdb9e
remove unuse i18n
samhvw8 Jul 25, 2025
3038800
fix test fail
samhvw8 Jul 26, 2025
8b43962
feat: address PR review comments
daniel-lxs Jul 28, 2025
1ead395
fix: update test to use maxTotalImageSize instead of maxTotalImageMemory
daniel-lxs Jul 28, 2025
701d5fc
fix: update webview test to use maxTotalImageSize
daniel-lxs Jul 28, 2025
32a68d2
refactor: move image processing logic to imageHelpers
daniel-lxs Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/types/src/global-settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ export const globalSettingsSchema = z.object({
maxWorkspaceFiles: z.number().optional(),
showRooIgnoredFiles: z.boolean().optional(),
maxReadFileLine: z.number().optional(),
maxImageFileSize: z.number().optional(),
maxTotalImageSize: z.number().optional(),

terminalOutputLineLimit: z.number().optional(),
terminalOutputCharacterLimit: z.number().optional(),
Expand Down
Loading