Skip to content

Conversation

@nonsleepr
Copy link

@nonsleepr nonsleepr commented Jun 27, 2025

Description:

  • Add requestDelaySeconds and maxRequestDelaySeconds settings (defaults: 5-100)
  • Convert single retry delay to configurable range with exponential backoff clamping
  • Update UI to use dual-thumb range slider for min/max selection
  • Add comprehensive test coverage for new range settings
  • Update all locale translations to reflect range concept

Related GitHub Issue

Closes: #5189, #2724
Improves upon #5171

Description

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Before:
image
After:
image

Documentation Updates

Documentation update is needed (it is outdated as of now).

Get in Touch

nonsleepr


Important

Implement retry delay range with min/max bounds, updating settings, UI, and tests.

  • Behavior:
    • Introduces requestDelaySeconds and maxRequestDelaySeconds settings for retry delay range with exponential backoff in Task.ts.
    • Updates ClineProvider to handle new delay settings and defaults.
    • UI updated to use dual-thumb slider for delay range in AutoApproveSettings.tsx.
  • Tests:
    • Adds tests for new delay settings in ClineProvider.spec.ts.
  • Localization:
    • Updates Indonesian locale in settings.json to reflect delay range concept.

This description was created by Ellipsis for fe4f691. You can customize this summary. It will automatically update as commits are pushed.

Description:
- Add requestDelaySeconds and maxRequestDelaySeconds settings (defaults: 1-100)
- Convert single retry delay to configurable range with exponential backoff clamping
- Update UI to use dual-thumb range slider for min/max selection
- Add comprehensive test coverage for new range settings
- Update all locale translations to reflect range concept
@nonsleepr nonsleepr requested review from cte, jr and mrubens as code owners June 27, 2025 14:21
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Jun 27, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 27, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 27, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 27, 2025
@daniel-lxs daniel-lxs marked this pull request as draft June 27, 2025 23:35
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Draft / In Progress] in Roo Code Roadmap Jun 27, 2025
@nonsleepr nonsleepr marked this pull request as ready for review July 3, 2025 04:11
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. UI/UX UI/UX related or focused and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 3, 2025
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@hannesrudolph
Copy link
Collaborator

Issue not approved.

@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request PR - Draft / In Progress size:XL This PR changes 500-999 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Exponential backoff retry delays can reach excessive wait times (20+ minutes) without user control

2 participants