Try to avoid type error from removing gemini-cli #5226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
✅ No security or compliance issues detected. Reviewed everything up to 96b4e6d. Security Overview
Detected Code Changes
Reply to this PR with |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| "vscode-lm", | ||
| "lmstudio", | ||
| "gemini", | ||
| "gemini-cli", |
Contributor
There was a problem hiding this comment.
If 'gemini-cli' is meant as an alias for 'gemini', update the discriminated union for consistency or document its special handling.
hannesrudolph
pushed a commit
that referenced
this pull request
Jul 3, 2025
utarn
pushed a commit
to modelharbor/ModelHarbor-Agent
that referenced
this pull request
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting lots of telemetry errors otherwise
Important
Add
"gemini-cli"toproviderNamesinprovider-settings.tsto prevent type errors, and add a placeholder changeset file."gemini-cli"toproviderNamesarray inprovider-settings.tsto prevent type errors when removed.public-bugs-hang.mdwith no specific content.This description was created by
for 96b4e6d. You can customize this summary. It will automatically update as commits are pushed.