Skip to content

Conversation

@PaperBoardOfficial
Copy link
Contributor

@PaperBoardOfficial PaperBoardOfficial commented Jun 29, 2025

Related GitHub Issue

Closes: #5229

Description

The issue occurred because the currentProfileId was using the provider model name not the id of the provider. Hence, it always picked the "default" context condensing threshold. Now, it correctly picks the right currentProfileId.

Test Procedure

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Fixes currentProfileId usage in Task.ts to ensure correct context condensing threshold by using provider ID instead of model name.

  • Behavior:
    • Fixes currentProfileId usage in Task.ts by using the provider ID instead of the model name.
    • Ensures correct context condensing threshold is applied in truncateConversationIfNeeded().
  • Misc:
    • Updates currentProfileId logic in attemptApiRequest() to match the fix.

This description was created by Ellipsis for 49ef16e. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jun 29, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 29, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @PaperBoardOfficial

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 30, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 30, 2025
@mrubens mrubens merged commit 8c493b3 into RooCodeInc:main Jun 30, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 30, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 30, 2025
utarn pushed a commit to modelharbor/ModelHarbor-Agent that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Profile Context Condense Threshold not working

4 participants