Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jun 30, 2025

Fixes issue #5141 by adding geminiDisableIntermediateReasoning setting to suppress malformed intermediate reasoning chunks that cause errors. When enabled, reasoning still works but intermediate results aren't streamed. Includes comprehensive tests.


Important

Adds geminiDisableIntermediateReasoning setting to control streaming of reasoning chunks in GeminiHandler, with comprehensive tests.

  • Behavior:
    • Adds geminiDisableIntermediateReasoning setting in provider-settings.ts to control streaming of intermediate reasoning chunks.
    • When enabled, suppresses reasoning chunks in GeminiHandler in gemini.ts.
  • Tests:
    • Adds tests in gemini.spec.ts to verify behavior with and without geminiDisableIntermediateReasoning enabled.
    • Tests ensure correct chunk processing and suppression of reasoning chunks when setting is enabled.

This description was created by Ellipsis for 8e233b3. You can customize this summary. It will automatically update as commits are pushed.

- Add geminiDisableIntermediateReasoning setting to Gemini provider schema
- Modify Gemini provider to suppress reasoning chunks when setting is enabled
- Add comprehensive tests for both enabled and disabled reasoning scenarios
- Reasoning still works but intermediate results aren't streamed when disabled
@roomote roomote requested review from cte, jr and mrubens as code owners June 30, 2025 07:50
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels Jun 30, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jun 30, 2025

No security or compliance issues detected. Reviewed everything up to 8e233b3.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 30, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants