Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jun 30, 2025

Summary

This PR addresses issue #5136 by adding comprehensive test coverage for the Groq provider's qwen/qwen3-32b model maxTokens validation.

Background

Issue #5136 reported that the Groq provider's qwen/qwen3-32b model was failing with "max_tokens must be less than or equal to 40960" error. Investigation revealed that this issue was already fixed in commit c797c9a, which correctly set the maxTokens to 40960 to match Groq's API documentation.

Changes

  • Added specific test case to verify qwen/qwen3-32b model has correct maxTokens value of 40960
  • This ensures the existing fix is properly tested and prevents future regression
  • All tests pass, confirming the fix is working correctly

Testing

  • ✅ All existing Groq provider tests pass
  • ✅ New test specifically validates qwen/qwen3-32b maxTokens = 40960
  • ✅ Lint and type checking pass

Related Issues

Fixes #5136

Notes

The actual fix was already implemented in commit c797c9a. This PR adds the missing test coverage to ensure the fix is properly validated and to prevent regression in the future.


Important

Add test in groq.spec.ts to verify qwen/qwen3-32b model's maxTokens is 40960, addressing issue #5136.

This description was created by Ellipsis for 1307037. You can customize this summary. It will automatically update as commits are pushed.

Fixes #5136

- Added specific test to verify qwen/qwen3-32b model has correct maxTokens value of 40960
- This ensures the fix from commit c797c9a is properly tested and prevents regression
- The maxTokens limit of 40960 matches Groq API documentation requirements
@roomote roomote requested review from cte, jr and mrubens as code owners June 30, 2025 07:54
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jun 30, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jun 30, 2025

No security or compliance issues detected. Reviewed everything up to 1307037.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Groq provider : Qwen3-32b - max_tokens must be less than or equal to 40960

3 participants