Skip to content

Fixes #5139: Improve YAML error line number extraction for .roomodes files #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roomote wants to merge 1 commit into from
Closed

Fixes #5139: Improve YAML error line number extraction for .roomodes files #5255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/core/config/CustomModesManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,23 @@ export class CustomModesManager {
const errorMsg = yamlError instanceof Error ? yamlError.message : String(yamlError)
console.error(`[CustomModesManager] Failed to parse YAML from ${filePath}:`, errorMsg)

const lineMatch = errorMsg.match(/at line (\d+)/)
const line = lineMatch ? lineMatch[1] : "unknown"
// Try multiple patterns to extract line number from YAML error messages
const linePatterns = [
/at line (\d+)/, // "at line X"
/line (\d+)/, // "line X"
/\((\d+):\d+\)/, // "(line:column)"
/(\d+):\d+/, // "line:column"
]

let line = "unknown"
for (const pattern of linePatterns) {
const match = errorMsg.match(pattern)
if (match) {
line = match[1]
break
}
}

vscode.window.showErrorMessage(t("common:customModes.errors.yamlParseError", { line }))

// Return empty object to prevent duplicate error handling
Expand Down