Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jun 30, 2025

  • Modified extractTextFromXLSX to accept maxRows option
  • Updated extractTextFromFile to pass row limit to Excel extraction
  • Modified readFileTool to apply maxReadFileLine setting to Excel files
  • Added comprehensive tests for row limiting functionality
  • Excel files now respect the same line limits as regular text files
  • Prevents 'input length too long' errors when reading large Excel files

Important

Apply row limit to Excel file processing in readFileTool and extractTextFromXLSX, with tests for row limiting functionality.

  • Behavior:
    • extractTextFromXLSX in extract-text-from-xlsx.ts now accepts maxRows option to limit rows processed.
    • readFileTool in readFileTool.ts applies maxReadFileLine to Excel files, truncating content if limit is exceeded.
    • Excel files now show truncation notice if row limit is applied.
  • Tests:
    • Added tests in extract-text-from-xlsx.test.ts for row limiting, including multiple sheets and empty rows.
  • Misc:
    • Renamed ROW_LIMIT to DEFAULT_ROW_LIMIT in extract-text-from-xlsx.ts.
    • Updated extractTextFromFile in extract-text.ts to pass maxRows to Excel extraction.

This description was created by Ellipsis for 27c4e2c. You can customize this summary. It will automatically update as commits are pushed.

- Modified extractTextFromXLSX to accept maxRows option
- Updated extractTextFromFile to pass row limit to Excel extraction
- Modified readFileTool to apply maxReadFileLine setting to Excel files
- Added comprehensive tests for row limiting functionality
- Excel files now respect the same line limits as regular text files
- Prevents 'input length too long' errors when reading large Excel files
@roomote roomote requested review from cte, jr and mrubens as code owners June 30, 2025 08:50
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 30, 2025
@dosubot dosubot bot added the bug Something isn't working label Jun 30, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jun 30, 2025

No security or compliance issues detected. Reviewed everything up to 27c4e2c.

Security Overview
  • 🔎 Scanned files: 4 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 30, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants