Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jun 30, 2025

  • Enhanced deleteCustomMode confirmation dialog to warn users when .roo/rules-{mode} folder exists
  • Added new translation key 'delete_custom_mode_with_rules' for enhanced warning message
  • Modified webview message handler to check for rules folder existence before showing confirmation
  • Added comprehensive tests covering all scenarios: enhanced warnings, standard warnings, error handling
  • Preserves existing behavior for modes without rules folders
  • Handles edge cases gracefully (no workspace, file check failures, mode not found)

Important

Enhance deleteCustomMode to warn users about associated rules folders, with comprehensive tests and edge case handling.

  • Behavior:
    • deleteCustomMode now warns if .roo/rules-{mode} folder exists, using new translation key delete_custom_mode_with_rules.
    • Preserves existing behavior for modes without rules folders.
    • Handles edge cases: no workspace, file check failures, mode not found.
  • Webview:
    • Modified webviewMessageHandler to check for rules folder before showing confirmation.
  • Tests:
    • Added tests in webviewMessageHandler.spec.ts for enhanced warnings, standard warnings, and error handling.

This description was created by Ellipsis for 3b3da61. You can customize this summary. It will automatically update as commits are pushed.

…lders

- Enhanced deleteCustomMode confirmation dialog to warn users when .roo/rules-{mode} folder exists
- Added new translation key 'delete_custom_mode_with_rules' for enhanced warning message
- Modified webview message handler to check for rules folder existence before showing confirmation
- Added comprehensive tests covering all scenarios: enhanced warnings, standard warnings, error handling
- Preserves existing behavior for modes without rules folders
- Handles edge cases gracefully (no workspace, file check failures, mode not found)
@roomote roomote requested review from cte, jr and mrubens as code owners June 30, 2025 09:38
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 30, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jun 30, 2025

No security or compliance issues detected. Reviewed everything up to 3b3da61.

Security Overview
  • 🔎 Scanned files: 3 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants