Fixes #5219: Make system prompt warning dismissible #5268
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add systemPromptWarningDismissed boolean setting to GlobalSettings schema - Update ExtensionState type to include the new setting - Add state management through ExtensionStateContext with getter and setter - Modify SystemPromptWarning component to include dismiss button with X icon - Update ChatView to conditionally render warning based on both hasSystemPromptOverride and !systemPromptWarningDismissed - Add test coverage for SystemPromptWarning component - Dismiss functionality persists user preference through extension state system
dosubot
bot
added
size:L
|
✅ No security or compliance issues detected. Reviewed everything up to f398eea. Security Overview
Detected Code ChangesThe diff is too large to display a summary of code changes. Reply to this PR with |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| <button | ||
| onClick={handleDismiss} | ||
| className="flex items-center justify-center w-5 h-5 ml-2 hover:bg-vscode-editor-background hover:bg-opacity-20 rounded" | ||
| title="Dismiss warning"> |
Contributor
There was a problem hiding this comment.
Consider using a translatable label for the dismiss button title (e.g., t('chat:dismissWarning')) instead of the hardcoded string.
Suggested change
| title="Dismiss warning"> | |
| title={t("chat:dismissWarning")}> |
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a dismissible system prompt warning as requested in issue #5219. Users can now dismiss the yellow warning box that appears when they have a custom system prompt override active, and their preference will be persisted. The warning includes a dismiss button (X icon) and the setting persists across VSCode sessions.
Important
Adds a dismissible system prompt warning feature with persistent state across sessions, including tests for functionality.
SystemPromptWarning.tsxwith a button to dismiss the warning.systemPromptWarningDismissedinExtensionStateContext.tsx.hasSystemPromptOverrideis true andsystemPromptWarningDismissedis false inChatView.tsx.systemPromptWarningDismissedtoglobalSettingsSchemainglobal-settings.ts.ExtensionStateinExtensionMessage.tsto includesystemPromptWarningDismissed.setSystemPromptWarningDismissedinExtensionStateContext.tsx.SystemPromptWarning.spec.tsxto test rendering, dismiss button functionality, and translation usage.This description was created by
for f398eea. You can customize this summary. It will automatically update as commits are pushed.