Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jun 30, 2025

Summary

This PR fixes the layout shifting and inconsistent spacing issues in the ChatView component as described in issue #5236.

Changes Made

1. Fixed AutoApproveMenu Positioning

  • Problem: AutoApproveMenu had different CSS classes when task exists vs doesn't exist, causing layout shifts
  • Solution: Standardized positioning using class for both states
  • Files:

2. Replaced Custom Scroll-to-Bottom Button

  • Problem: Custom styling for scroll-to-bottom button was inconsistent with other standard buttons
  • Solution: Replaced with standard component with
  • Files:

3. Standardized Action Button Area Spacing

  • Problem: Inconsistent spacing between UI elements at the bottom of ChatView
  • Solution: Added consistent spacing with fixed padding () in action button areas
  • Files:

Technical Details

The main issues were caused by:

  1. Different CSS classes ( vs ) for AutoApproveMenu positioning
  2. Custom button styling instead of using VSCode's standard button components
  3. Inconsistent padding and margin applications in action areas

Testing

  • All linting checks pass
  • TypeScript compilation successful
  • Layout shifts eliminated through consistent CSS class usage
  • Button styling now matches VSCode design system

Fixes

Closes #5236


Important

Fix layout shifting and inconsistent spacing in ChatView.tsx by standardizing CSS classes and button styling.

  • Layout Fixes:
    • Standardized AutoApproveMenu positioning in ChatView.tsx to prevent layout shifts by using consistent CSS classes.
    • Replaced custom scroll-to-bottom button with VSCodeButton for consistent styling.
    • Added consistent spacing and fixed padding for action button areas in ChatView.tsx.
  • Testing:
    • Verified layout shifts are eliminated and button styling matches VSCode design system.

This description was created by Ellipsis for 727515a. You can customize this summary. It will automatically update as commits are pushed.

- Standardize AutoApproveMenu positioning with flex-shrink-0 class for both task and no-task states
- Replace custom scroll-to-bottom button styling with standard VSCodeButton component
- Add consistent spacing with fixed padding in action button areas
- Eliminate layout shifts caused by different CSS classes between states
@roomote roomote requested review from cte, jr and mrubens as code owners June 30, 2025 10:30
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working UI/UX UI/UX related or focused labels Jun 30, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jun 30, 2025

No security or compliance issues detected. Reviewed everything up to 727515a.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 30, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 30, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 30, 2025
@seedlord
Copy link
Contributor

the initial issue and pr touched 4 files.

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to Triage in Roo Code Roadmap Jun 30, 2025
@hannesrudolph hannesrudolph added Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. and removed PR - Needs Preliminary Review labels Jun 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Inconsistent ChatView elements and layout shifting

4 participants