Skip to content

Conversation

@GOODBOY008
Copy link
Contributor

@GOODBOY008 GOODBOY008 commented Jun 30, 2025

This PR enhances the provider selection UI in the settings by adding a search/filter functionality.

  • Users can now type in a search box to filter the list of API providers, making it easier and faster to find the desired provider.
  • The UI uses a popover with a search input and dynamically filtered provider list.
  • Internationalization (i18n) support is included for new search-related strings.
  • Unit tests have been updated to cover the new functionality.

Test Procedure

  • Open the settings page and click the provider selection button.
  • Type in the search box to filter providers by name.
  • Verify that only matching providers are shown and that selecting a provider updates the selection.
  • Clear the search to see the full list again.
  • Confirm that the "No providers found" message appears when there are no matches.
  • Run the updated unit tests in ApiOptions.spec.tsx to ensure coverage for the new functionality.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue.
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).

Important

Enhances provider selection UI with search/filter functionality and updates tests and i18n support.

  • Behavior:
    • Adds search/filter functionality to provider selection UI in ApiOptions.tsx using a popover with a search input.
    • Displays "No providers found" message when no matches are found.
    • Updates selection when a provider is selected from the filtered list.
  • Internationalization:
    • Adds i18n support for new search-related strings in multiple locale files.
  • Testing:
    • Updates unit tests in ApiOptions.spec.tsx to cover new search functionality.
    • Mocks UI components in SettingsView.spec.tsx for testing purposes.

This description was created by Ellipsis for 19bf209. You can customize this summary. It will automatically update as commits are pushed.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 30, 2025
@GOODBOY008 GOODBOY008 force-pushed the feature/add-search-provider branch from 9493091 to bdbfa9c Compare June 30, 2025 11:52
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Jun 30, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 30, 2025
@GOODBOY008 GOODBOY008 force-pushed the feature/add-search-provider branch from bdbfa9c to 19bf209 Compare July 1, 2025 05:58
@GOODBOY008
Copy link
Contributor Author

GOODBOY008 commented Jul 1, 2025

Link discussion :#5277

@GOODBOY008 GOODBOY008 marked this pull request as ready for review July 1, 2025 06:02
@GOODBOY008 GOODBOY008 requested review from cte, jr and mrubens as code owners July 1, 2025 06:02
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused labels Jul 1, 2025
@GOODBOY008
Copy link
Contributor Author

@mrubens Can you help review this pr ? if you are available.

@daniel-lxs daniel-lxs moved this from PR [Draft / In Progress] to PR [Needs Prelim Review] in Roo Code Roadmap Jul 7, 2025
- Added SearchableSelect to the @/components/ui mock in SettingsView.spec.tsx
- This resolves test failures after the SearchableSelect component was introduced
- All 497 tests now pass successfully
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jul 8, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 8, 2025

No security or compliance issues detected. Reviewed everything up to c68c137.

Security Overview
  • 🔎 Scanned files: 26 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jul 8, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @GOODBOY008!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2025
- Replace hardcoded 'Select...' with i18n key 'settings:common.select'
- Ensures consistency with actual component usage
- Addresses PR review feedback
@mrubens mrubens merged commit 8c1aec1 into RooCodeInc:main Jul 8, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 8, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:XL This PR changes 500-999 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants