-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add Search/Filter Functionality to API Provider Selection in Settings #5278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Search/Filter Functionality to API Provider Selection in Settings #5278
Conversation
9493091 to
bdbfa9c
Compare
bdbfa9c to
19bf209
Compare
|
Link discussion :#5277 |
|
@mrubens Can you help review this pr ? if you are available. |
- Added SearchableSelect to the @/components/ui mock in SettingsView.spec.tsx - This resolves test failures after the SearchableSelect component was introduced - All 497 tests now pass successfully
|
✅ No security or compliance issues detected. Reviewed everything up to c68c137. Security Overview
Detected Code ChangesThe diff is too large to display a summary of code changes. Reply to this PR with |
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @GOODBOY008!
webview-ui/src/components/settings/__tests__/ApiConfigManager.spec.tsx
Outdated
Show resolved
Hide resolved
- Replace hardcoded 'Select...' with i18n key 'settings:common.select' - Ensures consistency with actual component usage - Addresses PR review feedback
This PR enhances the provider selection UI in the settings by adding a search/filter functionality.
Test Procedure
ApiOptions.spec.tsxto ensure coverage for the new functionality.Pre-Submission Checklist
Important
Enhances provider selection UI with search/filter functionality and updates tests and i18n support.
ApiOptions.tsxusing a popover with a search input.ApiOptions.spec.tsxto cover new search functionality.SettingsView.spec.tsxfor testing purposes.This description was created by
for 19bf209. You can customize this summary. It will automatically update as commits are pushed.