Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Jun 30, 2025

Description

This PR enhances the issue-fixer mode by integrating a translation workflow step to ensure all user-facing content changes are properly localized.

Changes Made

  • Added Step 7 "Check for Translation Requirements" to the issue-fixer workflow in .roo/rules-issue-fixer/1_Workflow.xml

    • Analyzes implementation for new user-facing strings, error messages, and documentation
    • Automatically delegates translation tasks to translate mode when needed
    • Ensures translations are completed before final testing
  • Updated best practices in .roo/rules-issue-fixer/2_best_practices.xml

    • Added guidelines for delegating translation tasks
    • Emphasized checking for hard-coded strings and i18n needs
    • Added note to wait for translation completion before final testing

Why This Change?

When fixing issues or implementing features, developers often introduce new user-facing content that needs to be translated into all supported languages. This workflow enhancement ensures that:

  1. Translation requirements are identified systematically
  2. No user-facing content is left untranslated
  3. The translation process is integrated seamlessly into the issue-fixing workflow
  4. All supported languages remain in sync

Testing

The workflow has been designed to:

  • Check for translation needs after implementation (Step 7)
  • Create detailed translation tasks with proper context
  • Wait for translation completion before proceeding to final tests

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic
  • Documentation updated
  • No breaking changes

Important

Adds a translation workflow step to issue-fixer mode, ensuring user-facing content is localized before final testing.

  • Workflow Changes:
    • Adds Step 7 "Check for Translation Requirements" in 1_Workflow.xml to identify and delegate translation tasks for new user-facing content.
    • Ensures translations are completed before final testing.
  • Best Practices:
    • Updates 2_best_practices.xml to include guidelines for delegating translation tasks and checking for hard-coded strings.
    • Emphasizes waiting for translation completion before final testing.

This description was created by Ellipsis for ada6924. You can customize this summary. It will automatically update as commits are pushed.

- Added step 7 to check for translation requirements after implementation
- Integrated translation mode delegation for user-facing content changes
- Updated best practices to include translation task delegation
- Ensures all new strings, error messages, and documentation are properly localized
Copilot AI review requested due to automatic review settings June 30, 2025 15:46
@hannesrudolph hannesrudolph requested review from cte, jr and mrubens as code owners June 30, 2025 15:46
@delve-auditor
Copy link

delve-auditor bot commented Jun 30, 2025

No security or compliance issues detected. Reviewed everything up to ada6924.

Security Overview
  • 🔎 Scanned files: 2 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► 1_Workflow.xml
    Added translation workflow step
    Updated step numbering sequence
► 2_best_practices.xml
    Added translation-related best practices

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR integrates a translation workflow into the issue-fixer mode and updates related best practices.

  • Inserts a new Step 7 in the workflow to detect and delegate translation tasks.
  • Renumbers subsequent steps (8→9, 9→10, 10→11, 11→12).
  • Adds translation and i18n checks to the best practices document.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.roo/rules-issue-fixer/1_Workflow.xml Added “Check for Translation Requirements” as Step 7 and renumbered later steps
.roo/rules-issue-fixer/2_best_practices.xml Added guidelines on delegating translation tasks and checking hard-coded strings
Comments suppressed due to low confidence (3)

.roo/rules-issue-fixer/1_Workflow.xml:287

  • [nitpick] The bracketed placeholder could be confusing if left literal; consider clarifying that this is a template field or provide an example to guide users.
       - [List specific files and what content needs translation]

.roo/rules-issue-fixer/2_best_practices.xml:15

  • [nitpick] Indentation is inconsistent with the existing bullet list; align this item to match the four-space indent of the other list entries.
  - Delegate translation tasks to translate mode when implementing user-facing changes

.roo/rules-issue-fixer/1_Workflow.xml:310

  • [nitpick] This tag is indented differently than neighboring steps; adjust its indentation level to stay consistent with the surrounding XML structure.
   <step number="8">

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Jun 30, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 30, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 30, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 30, 2025
@hannesrudolph hannesrudolph added PR - Needs Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 30, 2025
@mrubens mrubens merged commit 6b7cfdc into main Jul 1, 2025
32 checks passed
@mrubens mrubens deleted the feat/issue-fixer-translation-workflow branch July 1, 2025 14:32
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 1, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 1, 2025
utarn pushed a commit to modelharbor/ModelHarbor-Agent that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants