fix: ensure VersionIndicator only shows on welcome screen

[hannesrudolph]

Description

This PR fixes failing tests in the ChatView component where the VersionIndicator was appearing when a task was active, despite tests expecting it to only show on the welcome screen.

Changes Made

• Moved VersionIndicator inside the welcome screen conditional block (!task) in ChatView.tsx
• Fixed the mock implementation in ChatView.spec.tsx to use the correct import path (../../common/VersionIndicator)
• Updated the mock to properly handle Vitest hoisting issues using vi.mocked
• Ensured tests that need to interact with VersionIndicator can override the mock

Testing

• All existing tests pass
• Ran the full ChatView test suite: 21 tests passing
• Verified VersionIndicator only appears when no task exists (welcome screen)
• Verified VersionIndicator does not appear when there is an active task

Technical Details

The issue was caused by:

1. The VersionIndicator component being placed outside the conditional rendering logic
2. The mock path not matching the actual import path in the source file
3. Vitest hoisting issues when accessing mock variables

The fix ensures proper conditional rendering and correct mocking behavior.

Checklist

• Code follows project style guidelines
• Self-review completed
• Tests updated and passing
• No breaking changes

---

Important

Fix VersionIndicator in ChatView to only display on the welcome screen and update tests accordingly.

• Behavior:
  • Move VersionIndicator inside the welcome screen conditional block in ChatView.tsx to ensure it only shows when no task is active.
  • Update ChatView.spec.tsx to mock VersionIndicator using the correct import path and handle Vitest hoisting issues with vi.mocked.
  • Ensure tests can override the VersionIndicator mock when needed.
• Testing:
  • Verified VersionIndicator only appears on the welcome screen and not when a task is active.
  • All existing tests pass, including 21 tests in the full ChatView test suite.

^{This description was created by for 6daaf22. You can customize this summary. It will automatically update as commits are pushed.}

[Copilot]

Pull Request Overview

This PR resolves failing tests by ensuring the VersionIndicator is only rendered on the welcome screen when there is no active task. Key changes include:

• Moving the VersionIndicator component inside the welcome screen conditional in ChatView.tsx.
• Updating the VersionIndicator mock in ChatView.spec.tsx to use the correct import path and handling for Vitest hoisting.
• Adjusting the container styling in ChatView.tsx to support proper absolute positioning of the VersionIndicator.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
webview-ui/src/components/chat/tests/ChatView.spec.tsx	Updated the mock implementation, import path, and temporary overrides for VersionIndicator tests
webview-ui/src/components/chat/ChatView.tsx	Moved VersionIndicator into the conditional rendering block and updated container styling

Comments suppressed due to low confidence (1)

webview-ui/src/components/chat/tests/ChatView.spec.tsx:1158

• [nitpick] Ensure that the aria-label values for the VersionIndicator mock are consistent across tests to avoid confusion; consider unifying the label ('Version 3.22.5' vs 'chat:versionIndicator.ariaLabel') for clarity.

					aria-label="Version 3.22.5">

[delve-auditor]

✅ No security or compliance issues detected. Reviewed everything up to 6daaf22.

Security Overview

• 🔎 Scanned files: 2 changed file(s)

Detected Code Changes

Change Type	Relevant files
Refactor	► ChatView.tsx     Relocated version indicator component     Updated component positioning ► ChatView.spec.tsx     Extracted version indicator mock into helper function     Updated version indicator tests

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.