Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jul 1, 2025

Don't do this (see mermaid-js/mermaid#4359)

Screenshot 2025-07-01 at 10 19 05 AM


Important

Set suppressErrorRendering: true in MermaidBlock.tsx to prevent error messages from displaying in rendered diagrams.

  • Behavior:
    • Set suppressErrorRendering: true in mermaid.initialize() in MermaidBlock.tsx to prevent error messages from being displayed in rendered diagrams.

This description was created by Ellipsis for 08c0351. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners July 1, 2025 14:19
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 1, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 1, 2025

No security or compliance issues detected. Reviewed everything up to 08c0351.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► MermaidBlock.tsx
    Add suppressErrorRendering configuration for Mermaid

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 1, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jul 1, 2025
@adamhill
Copy link
Contributor

adamhill commented Jul 1, 2025

🙏

@mrubens mrubens merged commit a1ae29c into main Jul 1, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 1, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 1, 2025
@mrubens mrubens deleted the suppress_mermaid_error_rendering branch July 1, 2025 19:50
hannesrudolph pushed a commit that referenced this pull request Jul 3, 2025
utarn pushed a commit to modelharbor/ModelHarbor-Agent that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants