Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jul 1, 2025

Summary

This PR implements the feature request from issue #5293 to add a share button next to the send button for improved discoverability of the task sharing functionality.

Changes Made

1. Added ShareButton to ChatTextArea

  • Added ShareButton component to the bottom toolbar of ChatTextArea, positioned before the send button
  • ShareButton is disabled when send is disabled to maintain consistent UX
  • Reuses existing share functionality for seamless integration

2. Enhanced ShareButton Component

  • Added optional allowNoItem prop to ShareButton component
  • When allowNoItem={true}, the ShareButton renders even when there's no current task
  • Maintains backward compatibility with existing usage

3. Updated Button Text Translations

  • Changed 'Start New Task' to 'Start Task' across all 18 supported languages:
    • English: 'Start New Task' → 'Start Task'
    • Chinese (Simplified): '开始新任务' → '开始任务'
    • Chinese (Traditional): '開始新工作' → '開始工作'
    • Russian: 'Начать новую задачу' → 'Начать задачу'
    • And 14 other languages

Technical Details

  • Files Modified: 20 files total

    • 1 component enhancement (ShareButton.tsx)
    • 1 component integration (ChatTextArea.tsx)
    • 18 translation files updated
  • Backward Compatibility: All existing ShareButton usage remains unchanged

  • Type Safety: All changes are fully typed with TypeScript

  • Accessibility: Maintains existing accessibility patterns

Testing

  • ✅ All linting checks passed
  • ✅ All type checking passed
  • ✅ Existing functionality preserved
  • ✅ New functionality integrated seamlessly

UI/UX Impact

  • Improved discoverability of share functionality
  • Cleaner, more concise button text
  • Consistent button states (disabled when appropriate)
  • Maintains existing design patterns

Closes #5293


Important

Add a share button to ChatTextArea.tsx and update 'Start New Task' to 'Start Task' in 18 languages.

  • Behavior:
    • Add ShareButton to ChatTextArea.tsx, positioned before the send button, disabled when send is disabled.
    • ShareButton uses existing share functionality.
  • Component Enhancements:
    • Add allowNoItem prop to ShareButton in ShareButton.tsx to render without a current task.
  • Translations:
    • Update 'Start New Task' to 'Start Task' in 18 language files, including English, Chinese, Russian, etc.
  • Misc:
    • Ensure backward compatibility for ShareButton usage.
    • All changes are fully typed with TypeScript.

This description was created by Ellipsis for 6b17ae3. You can customize this summary. It will automatically update as commits are pushed.

…New Task' to 'Start Task'

- Added ShareButton component to ChatTextArea bottom toolbar next to send button
- Modified ShareButton to support allowNoItem prop for rendering without current task
- Updated all 18 translation files to change 'Start New Task' to 'Start Task'
- ShareButton is disabled when send is disabled to maintain consistent UX
- Reuses existing share functionality for improved discoverability
@roomote roomote requested review from cte, jr and mrubens as code owners July 1, 2025 15:58
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused labels Jul 1, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 1, 2025

No security or compliance issues detected. Reviewed everything up to 6b17ae3.

Security Overview
  • 🔎 Scanned files: 20 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 1, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 7, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:M This PR changes 30-99 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add share button next to "Start New Task" for improved discoverability

3 participants