Skip to content

Conversation

@SannidhyaSah
Copy link
Collaborator

@SannidhyaSah SannidhyaSah commented Jul 1, 2025

Description

Fixes #5165

This PR removes the context size indicator from the environment details to address the issue where the context size was being included in the actual context, creating a recursive problem that inflated token usage.

Changes Made

  • Commented out the context size calculation and display in src/core/environment/getEnvironmentDetails.ts
  • Updated the corresponding test in src/core/environment/__tests__/getEnvironmentDetails.spec.ts to reflect this change

Testing

  • All existing tests pass
  • Updated test for getEnvironmentDetails to verify context size is no longer included
  • Manual testing completed:
    • Verified environment details no longer include context size
    • Confirmed the function still returns all other environment information correctly

Verification of Acceptance Criteria

  • Context size indicator removed from environment details output
  • No breaking changes to other environment detail functionality
  • Tests updated to reflect the change

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Comments added for complex logic (N/A - simple removal)
  • Documentation updated (if needed) (N/A)
  • No breaking changes
  • Accessibility checked (N/A - backend change only)

Important

Removes context size from environment details in getEnvironmentDetails.ts to prevent recursive token inflation, updating tests accordingly.

  • Behavior:
    • Removes context size from getEnvironmentDetails() in getEnvironmentDetails.ts to prevent recursive token inflation.
    • Updates test in getEnvironmentDetails.spec.ts to ensure context size is not included.
  • Testing:
    • All existing tests pass.
    • Manual verification confirms context size is excluded and other details remain correct.

This description was created by Ellipsis for bf5e44c. You can customize this summary. It will automatically update as commits are pushed.

@SannidhyaSah SannidhyaSah requested review from cte, jr and mrubens as code owners July 1, 2025 17:05
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Jul 1, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 1, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jul 1, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jul 1, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jul 1, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 1, 2025
@mrubens mrubens merged commit ff1e8ac into RooCodeInc:main Jul 1, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jul 1, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 1, 2025
@SannidhyaSah SannidhyaSah deleted the fix/issue-5165-remove-context-indicators branch July 2, 2025 04:41
hannesrudolph pushed a commit that referenced this pull request Jul 3, 2025
Co-authored-by: Matt Rubens <[email protected]>
Co-authored-by: Daniel Riccio <[email protected]>
Co-authored-by: Daniel <[email protected]>
utarn pushed a commit to modelharbor/ModelHarbor-Agent that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer PR - Needs Review size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove context indicators from model-facing environment details

4 participants