-
Notifications
You must be signed in to change notification settings - Fork 2.6k
fix: remove context size from environment details (#5165) #5312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrubens
merged 4 commits into
RooCodeInc:main
from
SannidhyaSah:fix/issue-5165-remove-context-indicators
Jul 1, 2025
Merged
fix: remove context size from environment details (#5165) #5312
mrubens
merged 4 commits into
RooCodeInc:main
from
SannidhyaSah:fix/issue-5165-remove-context-indicators
Jul 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-lxs
approved these changes
Jul 1, 2025
mrubens
reviewed
Jul 1, 2025
Co-authored-by: Matt Rubens <[email protected]>
mrubens
approved these changes
Jul 1, 2025
hannesrudolph
pushed a commit
that referenced
this pull request
Jul 3, 2025
Co-authored-by: Matt Rubens <[email protected]> Co-authored-by: Daniel Riccio <[email protected]> Co-authored-by: Daniel <[email protected]>
utarn
pushed a commit
to modelharbor/ModelHarbor-Agent
that referenced
this pull request
Jul 4, 2025
…ooCodeInc#5312) Co-authored-by: Matt Rubens <[email protected]> Co-authored-by: Daniel Riccio <[email protected]> Co-authored-by: Daniel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
lgtm
This PR has been approved by a maintainer
PR - Needs Review
size:XS
This PR changes 0-9 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5165
This PR removes the context size indicator from the environment details to address the issue where the context size was being included in the actual context, creating a recursive problem that inflated token usage.
Changes Made
src/core/environment/getEnvironmentDetails.tssrc/core/environment/__tests__/getEnvironmentDetails.spec.tsto reflect this changeTesting
getEnvironmentDetailsto verify context size is no longer includedVerification of Acceptance Criteria
Checklist
Important
Removes context size from environment details in
getEnvironmentDetails.tsto prevent recursive token inflation, updating tests accordingly.getEnvironmentDetails()ingetEnvironmentDetails.tsto prevent recursive token inflation.getEnvironmentDetails.spec.tsto ensure context size is not included.This description was created by
for bf5e44c. You can customize this summary. It will automatically update as commits are pushed.