feat: Delete .roo/rules-{mode} folder when custom mode is deleted (#5210)

[hannesrudolph]

Pull Request for Issue #5210

Changes Made

• Implemented two-phase deletion process to check for rules folder existence before showing confirmation dialog.
• Added confirmation dialog in the webview that displays the actual path of the rules folder, if it exists.
• Updated path resolution to handle both global and project-specific rules folders.
• Added necessary translations for the rules folder deletion confirmation in all supported languages.
• Improved error handling during folder deletion to provide feedback if the deletion fails.

Verification

• All existing tests pass successfully (2589 tests).
• Verified that deleting custom modes appropriately deletes their corresponding .roo/rules-{mode} folders.
• Confirmed translation keys display correctly across all languages.
• Ensured appropriate error handling during folder deletion.

Related Issues

Resolves #5210: Deleting a custom mode now deletes its corresponding .roo/rules-{mode} folder.

Checklist

• Code follows project style guidelines
• Self-review completed
• Comments added for complex logic
• Documentation updated (if needed)
• No breaking changes (or documented if any)
• Accessibility checked (for UI changes)

---

Important

This PR adds functionality to delete the .roo/rules-{mode} folder when a custom mode is deleted, including UI updates, error handling improvements, and translations.

• Behavior:
  • Implements two-phase deletion process in webviewMessageHandler.ts to check for rules folder existence before confirming deletion.
  • Adds confirmation dialog in DeleteModeDialog.tsx showing the path of the rules folder if it exists.
  • Updates path resolution for global and project-specific rules folders.
  • Improves error handling during folder deletion, logging errors and notifying users.
• Tests:
  • Adds tests in webviewMessageHandler.spec.ts for deleting modes and handling errors.
• Translations:
  • Adds translations for deletion confirmation in common.json across multiple languages including ca, de, en, es, fr, hi, id, it, ja, ko, nl, pl, pt-BR, ru, tr, vi, zh-CN, zh-TW.
• Misc:
  • Adds deleteCustomModeCheck message type in ExtensionMessage.ts and WebviewMessage.ts.

^{This description was created by for 34fffef. You can customize this summary. It will automatically update as commits are pushed.}

[Copilot]

Pull Request Overview

Adds a two-step deletion flow for custom modes that ensures any associated .roo/rules-{mode} folder is discovered and confirmed in the UI before removal.

• Introduce a checkOnly flag in webview messages to fetch and relay the rules-folder path.
• Update the WebView component (ModesView.tsx) to show a confirmation dialog with the actual folder path.
• Extend message handler in webviewMessageHandler.ts to detect, report, and delete the rules folder, with translations and error handling.
• Add new translation keys and update existing ones across all locales.
• Expand unit tests to cover deletion and folder-removal behaviors.

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
webview-ui/src/i18n/locales/*/prompts.json	Added deleteMode dialog keys in all languages
webview-ui/src/components/modes/ModesView.tsx	Implemented AlertDialog for delete confirmation
src/shared/WebviewMessage.ts	Added checkOnly to the webview message interface
src/shared/ExtensionMessage.ts	Added deleteCustomModeCheck, rulesFolderExists and rulesFolderPath
src/core/webview/webviewMessageHandler.ts	Handle checkOnly, determine folder existence and perform deletion
src/core/webview/tests/webviewMessageHandler.spec.ts	Added tests for delete-mode logic and folder deletion
src/i18n/locales/*/common.json	Updated confirmation strings with rules-folder placeholders

Comments suppressed due to low confidence (3)

webview-ui/src/components/modes/ModesView.tsx:1440

• When there's no rules folder path, the generic message is still shown. To improve clarity, render t("prompts:deleteMode.descriptionNoRules") instead of the message key when rulesFolderPath is undefined.

									{t("prompts:deleteMode.message", { modeName: modeToDelete.name })}

src/core/webview/webviewMessageHandler.ts:1521

• The new confirmation translation in common.json uses {scope} and {rulesFolderPath}, but the rest of the UI uses {{scope}}/{{rulesFolderPath}} interpolation syntax. For consistency with other i18n keys, update these placeholders to double braces.

						type: "deleteCustomModeCheck",

src/core/webview/tests/webviewMessageHandler.spec.ts:366

• There are tests for the full deletion path, but none that simulate a checkOnly: true message. Add a test to assert that when checkOnly is sent, postMessageToWebview is called with deleteCustomModeCheck and the correct folder info.

describe("webviewMessageHandler - deleteCustomMode", () => {

[delve-auditor]

✅ No security or compliance issues detected. Reviewed everything up to 34fffef.

Security Overview

• 🔎 Scanned files: 42 changed file(s)

Detected Code Changes

Change Type	Relevant files
Bug Fix	► webviewMessageHandler.spec.ts     Update tests to match fs import style
Enhancement	► webviewMessageHandler.ts     Enhance mode deletion with rules folder handling ► DeleteModeDialog.tsx     Add new delete mode confirmation dialog ► ModesView.tsx     Implement enhanced mode deletion flow
Configuration changes	► locales/*.json     Add new translations for mode deletion

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

[daniel-lxs]

LGTM

[mrubens]

Looks like we got some conflicts, sorry!