-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: add markdown support to codebase indexing (#4660) #5378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mrubens
merged 10 commits into
RooCodeInc:main
from
MuriloFP:feat/issue-4660-markdown-indexing
Jul 4, 2025
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
28745d1
feat: add markdown support to codebase indexing (#4660)
MuriloFP d3d1d75
Merge branch 'RooCodeInc:main' into feat/issue-4660-markdown-indexing
MuriloFP a72f407
Merge branch 'RooCodeInc:main' into feat/issue-4660-markdown-indexing
MuriloFP b93c1fd
fix: implement chunking for large markdown sections and fix Qdrant de…
MuriloFP fae4460
Merge branch 'feat/issue-4660-markdown-indexing' of https://github.co…
MuriloFP e2c14fc
fix: remove redundant supported-extensions test file
MuriloFP d53e627
test: address PR review feedback
MuriloFP 0768c5e
fix: add segmentHash to vector point payload and refactor tests
MuriloFP 4eaf223
refactor: move redundant tests
daniel-lxs 5e74d28
feat: enhance markdown processing with consistent chunking logic and …
daniel-lxs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some test overlap between this file and
src/services/tree-sitter/__tests__/markdownIntegration.spec.ts. Both test:The overlap isn't necessarily a problem since they're testing different layers (indexing vs tree-sitter), but it might be cleaner to focus each suite on its core purpose:
MIN_BLOCK_CHARSlogicmarkdownIntegration.spec.ts: integration-level behaviorThis would reduce redundancy and make the intent of each suite clearer. What do you think?