Preserve focus when opening diff editor #5380
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kilo Code PR: Kilo-Org/kilocode#981
Related GitHub Issue
Contributes to #4784, not sure if it resolves it completely.
Description
When Roo edits a file the diff view steals focus from whatever had focus (probably the chat window text area). Specifying
preserveFocushere prevents this from happening (in some cases at least). SincepreserveFocusis specified in many places in the code base, here might be an oversight/regression.Test Procedure
Get in Touch
chrarnoldus on Discord, Christiaan on Kilo Code Slack
Important
Adds
preserveFocustoshowTextDocumentinDiffViewProvider.tsto maintain focus during diff editor opening, with corresponding tests inDiffViewProvider.spec.ts.preserveFocus: truetoshowTextDocumentinDiffViewProvider.tsto prevent focus loss when opening diff editor.DiffViewProvider.spec.tsto check forpreserveFocusoption inshowTextDocumentcall.showTextDocumentis called withpreserveFocus: trueinDiffViewProvider.spec.ts.executeCommandfollowsshowTextDocumentinDiffViewProvider.spec.ts.showTextDocumentfailure inDiffViewProvider.spec.ts.This description was created by
for 24c704d. You can customize this summary. It will automatically update as commits are pushed.