Skip to content

Conversation

@MuriloFP
Copy link
Contributor

@MuriloFP MuriloFP commented Jul 4, 2025

Related GitHub Issue

Closes: #[ISSUE_NUMBER]

Roo Code Task Context (Optional)

[Task context if available]

Description

This PR enhances the issue-fixer-orchestrator mode by adding quality gates and user interaction points before code is committed and pull requests are created. The key implementation changes include:

  • Pre-commit Review Stage: Added Step 10 that shows users exactly what files will be committed, generates a diff (or summary for large changes), and requires explicit user confirmation before proceeding
  • Flexible PR Creation: Modified Step 11 to offer multiple PR creation options - automatic, manual, or skip
  • PR Template Compliance: Implemented the exact Roo Code PR template format to ensure all PRs follow contribution guidelines
  • Improved User Control: Users can now review changes, test manually, modify PR messages, or cancel at key decision points

Design choices:

  • Large diffs (>2000 lines) automatically generate a summary to avoid overwhelming the review interface
  • PR messages are saved to the temp directory in both JSON and Markdown formats for maximum flexibility
  • All checklist items that can be verified programmatically are pre-checked
  • The workflow maintains all context files until the user explicitly approves cleanup

Test Procedure

To test these changes:

  1. Manual Testing Steps:

    • Create a test issue in a repository
    • Run the issue-fixer-orchestrator mode with the issue URL
    • Verify the new pre-commit review step shows staged files and diff
    • Test with a large change to verify summary generation works
    • Confirm PR message is saved to temp directory
    • Test each user decision path (approve, report issues, manual test)
    • Verify PR creation options work correctly
  2. Verification Points:

    • Check that only files from modified_files.json are staged
    • Verify PR message follows exact template format
    • Confirm all context files are preserved until cleanup
    • Test that large diffs (>2000 lines) generate summaries
  3. Edge Cases:

    • Test with no changes to commit
    • Test with very large changesets
    • Test cancellation at various points

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A - No UI changes

Documentation Updates

  • No documentation updates are required.

Additional Notes

This PR significantly improves the user experience of the issue-fixer-orchestrator mode by adding transparency and control at critical points in the workflow. The changes are backward compatible and don't affect existing functionality.

Get in Touch

@MuriloFP


Important

Enhances issue-fixer-orchestrator with pre-commit review, PR template, and improved user interaction for PR creation.

  • Pre-commit Review:
    • Adds Step 10 to review staged files and generate diffs, requiring user confirmation before commit.
    • Large diffs (>2000 lines) generate a summary instead of full diff.
  • PR Template:
    • Implements Roo Code PR template in 10_pr_template_format.xml.
    • Saves PR messages in JSON (pr_summary.json) and Markdown (pr_message.md) formats.
  • Workflow Changes:
    • Modifies Step 11 to offer PR creation options: automatic, manual, or skip.
    • Ensures all context files are maintained until user approves cleanup.
  • User Interaction:
    • Provides options for user to approve, report issues, or modify PR message before proceeding.
    • Offers cleanup of temporary files post-PR creation.

This description was created by Ellipsis for f2062ea. You can customize this summary. It will automatically update as commits are pushed.

- Add user confirmation step before committing changes
- Handle large diffs (>2000 lines) with summary generation
- Save PR message to temp directory instead of creating PR directly
- Implement exact Roo Code PR template format
- Add post-commit options for flexible PR creation
- Update best practices and communication guidelines
- Document new commit and PR workflow patterns
@MuriloFP MuriloFP requested review from cte, jr and mrubens as code owners July 4, 2025 22:34
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. enhancement New feature or request labels Jul 4, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 4, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2025
@mrubens mrubens merged commit 6982b19 into RooCodeInc:main Jul 5, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 5, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants