Pr fixer improvements

[MuriloFP]

Related GitHub Issue

Closes: #[ISSUE_NUMBER]

Roo Code Task Context (Optional)

No Roo Code task context for this PR.

Description

This PR enhances the pr-fixer-orchestrator workflow to provide better safety, user control, and context management.

Key Changes:

• User Approval Checkpoint: Added a new Step 9 that requires explicit user approval before committing any changes. This prevents unexpected modifications from being committed without review.
• Large Diff Handling: Implemented automatic summarization for diffs exceeding 2000 lines to prevent context window overflow and improve readability.
• Selective File Staging: Replaced the dangerous git add -A with targeted file staging to prevent accidentally committing unintended files.
• Context Preservation: Updated all delegation instructions to explicitly require saving outputs to the shared temp directory (.roo/temp/pr-fixer-orchestrator/[TASK_ID]/).
• PR Template Standardization: Created a new file (6_pr_template_format.xml) that defines the exact PR message format to be used.

Design Decisions:

• Chose 2000 lines as the threshold for large diffs based on typical context window limitations
• Made user approval a blocking step rather than optional to ensure full control
• Kept the temp directory structure consistent with other orchestrator modes for familiarity

Trade-offs:

• The workflow is now slightly slower due to the approval step, but this ensures safety
• More verbose delegation instructions, but this prevents common mistakes

Test Procedure

Testing performed:

1. Manually tested the workflow with a sample PR that had:
   • Review comments to address
   • Merge conflicts to resolve
   • Test failures to fix
2. Verified that:
   • User approval prompt appears before commit
   • Large diffs generate summaries correctly
   • Files are staged selectively
   • All delegated tasks save to the correct directory

To verify these changes:

1. Create a test PR with some issues (conflicts, review comments)
2. Run the pr-fixer-orchestrator mode with the PR URL
3. Observe that:
   • The workflow pauses for approval before committing
   • Only intended files are staged
   • Context files are properly shared between steps
   • PR update message follows the new template

Test Environment:

• Roo Code Extension version: [current version]
• VS Code version: [version]
• OS: Windows 11

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Testing: New and/or updated tests have been added to cover my changes (if applicable).
• Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

No UI changes in this PR.

Documentation Updates

• No documentation updates are required.

Additional Notes

This change makes the pr-fixer-orchestrator workflow significantly safer by ensuring users have full control over what gets committed. The workflow now follows the principle of "explicit is better than implicit" for all potentially destructive operations.

Files Modified:
.roo/rules-pr-fixer-orchestrator/1_workflow.xml - Updated main workflow with new safety features
.roo/rules-pr-fixer-orchestrator/2_best_practices.xml - Enhanced best practices and guidelines
.roo/rules-pr-fixer-orchestrator/6_pr_template_format.xml - New file defining PR message format

Get in Touch

Discord: @MuriloFP

---

Important

Introduces pr-fixer-orchestrator mode to enhance PR fixing workflow with detailed steps, best practices, GitHub CLI usage, and a standardized PR template.

• Workflow Enhancements:
  • Adds pr-fixer-orchestrator mode in .roomodes for coordinating PR fixes.
  • Implements a detailed workflow in 1_Workflow.xml for PR analysis, implementation, testing, and review.
  • Introduces user approval checkpoints and selective file staging.
• Best Practices:
  • Defines orchestration principles and guidelines in 2_best_practices.xml.
  • Emphasizes context preservation and user approval before committing.
• GitHub CLI Usage:
  • Details GitHub CLI commands for PR operations in 3_github_cli_usage.xml.
  • Includes commands for viewing PR details, checking CI status, and commenting.
• Requirements Analysis:
  • Provides guidelines for understanding PR requirements in 4_requirements_analysis.xml.
  • Lists sources of requirements and analysis steps.
• Self-Contained Workflow:
  • Ensures the orchestrator is independent in 5_self_contained_workflow.xml.
  • Describes handling of different PR types and fallback strategies.
• PR Template:
  • Establishes a standard PR message format in 6_pr_template_format.xml.
  • Includes placeholders for issue numbers, descriptions, and test procedures.

^{This description was created by for f389189. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

The multi-line commit message provided in the git commit command may cause issues with shell interpretation. Consider using a heredoc or proper newline escaping for reliability.