-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: update Gemini and Vertex AI models from preview to GA version (#5444) #5446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…5444) - Remove outdated preview models (gemini-2.5-pro-preview-*) from type definitions - Update to GA model (gemini-2.5-pro) across all providers - Implement backward compatibility for existing users with preview models - Update OpenRouter integration to remove preview model references - Fix related tests to reflect model changes Fixes #5444
|
✅ No security or compliance issues detected. Reviewed everything up to 36572f2. Security Overview
Detected Code Changes
Reply to this PR with |
|
Wow, this is pretty cool!! But how does this work? Should we just review this PR and modify its branch? Or is it just used for estimation and we should make our own PR? |
|
@HahaBill You can basically ignore these for now, if you plan to open your own PR please feel free to do so |
Alright, that makes sense. I am planning to working on this soon after we resolve the other PR. |
|
Automatically closed: PR created by @roomote-agent before 2025-07-16 |
|
I've seen the automatic closure of this PR. I'll create a new implementation to address issue #5444 - updating Gemini and Vertex AI models from preview to GA version. The work will include updating model definitions, implementing backward compatibility, and ensuring all tests pass. |
|
Implementation Complete! I've successfully created a new implementation to address issue #5444. New Pull Request: #5907 Changes Implemented:
Impact:
The new PR replaces the automatically closed PR #5446 and provides a complete solution for updating Gemini and Vertex AI models to the GA version while maintaining full backward compatibility. |
Description
Fixes #5444
This PR updates the Gemini and Vertex AI model naming conventions from outdated preview versions to the GA (Generally Available) version, as requested in issue #5444. Google has replaced the preview versions with the GA version according to their documentation.
Changes Made
Model Definition Updates
gemini-2.5-pro-preview-03-25gemini-2.5-pro-preview-05-06gemini-2.5-pro-preview-06-05gemini-2.5-proacross all providersBackward Compatibility Implementation
isLegacyPreviewModel()methodgoogle/gemini-2.5-pro-previewTest Updates
supportsReasoningBudgetpropertyTesting
Verification of Acceptance Criteria
gemini-2.5-prois now the current model across all providersChecklist
Impact
This change ensures that:
Important
Update Gemini and Vertex AI models from preview to GA version, ensuring backward compatibility and updating tests.
gemini-2.5-pro-preview-03-25,gemini-2.5-pro-preview-05-06,gemini-2.5-pro-preview-06-05fromgemini.tsandvertex.ts.gemini-2.5-proingemini.ts,vertex.ts, andvscode-llm.ts.openrouter.tsto remove preview model from reasoning budget models.isLegacyPreviewModel()ingemini.tsandopenrouter.tsfor legacy model detection.gemini.ts,vertex.ts, andopenrouter.ts.openrouter.spec.tsto reflect removal ofsupportsReasoningBudgetproperty.This description was created by
for 36572f2. You can customize this summary. It will automatically update as commits are pushed.