Skip to content

Fix model search being prefilled on dropdown #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 2 commits into from
Jul 7, 2025
Merged

Fix model search being prefilled on dropdown #5449

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91d523e
Fix model search being prefilled on dropdown
kevinvandijk Jul 7, 2025
7f64f6a
Add changeset
kevinvandijk Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 14 additions & 17 deletions webview-ui/src/components/settings/ModelPicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const ModelPicker = ({

const { id: selectedModelId, info: selectedModelInfo } = useSelectedModel(apiConfiguration)

const [searchValue, setSearchValue] = useState(selectedModelId || "")
const [searchValue, setSearchValue] = useState("")

const onSelect = useCallback(
(modelId: string) => {
Expand All @@ -87,28 +87,25 @@ export const ModelPicker = ({
}

// Delay to ensure the popover is closed before setting the search value.
selectTimeoutRef.current = setTimeout(() => setSearchValue(modelId), 100)
selectTimeoutRef.current = setTimeout(() => setSearchValue(""), 100)
},
[modelIdKey, setApiConfigurationField],
)

const onOpenChange = useCallback(
(open: boolean) => {
setOpen(open)
const onOpenChange = useCallback((open: boolean) => {
setOpen(open)

// Abandon the current search if the popover is closed.
if (!open) {
// Clear any existing timeout
if (closeTimeoutRef.current) {
clearTimeout(closeTimeoutRef.current)
}

// Delay to ensure the popover is closed before setting the search value.
closeTimeoutRef.current = setTimeout(() => setSearchValue(selectedModelId), 100)
// Abandon the current search if the popover is closed.
if (!open) {
// Clear any existing timeout
if (closeTimeoutRef.current) {
clearTimeout(closeTimeoutRef.current)
}
},
[selectedModelId],
)

// Clear the search value when closing instead of prefilling it
closeTimeoutRef.current = setTimeout(() => setSearchValue(""), 100)
}
}, [])

const onClearSearch = useCallback(() => {
setSearchValue("")
Expand Down