Skip to content

chore(deps): update node.js to v20.19.5 #5456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

chore(deps): update node.js to v20.19.5 #5456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v20.19.2
20.19.5
Copy link

@roomote roomote bot Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] The leading 'v' was removed (was 'v20.19.2' -> now '20.19.5'). Some tools and scripts expect the canonical 'v' prefix in .nvmrc. Suggest keeping the prefix for consistency with prior file and common nvm conventions.

Suggested change
20.19.5
v20.19.5

2 changes: 1 addition & 1 deletion .tool-versions
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 20.19.2
nodejs 20.19.5
Copy link

@roomote roomote bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Consider also pinning pnpm here to mirror packageManager ([email protected]) so asdf-managed environments use the same pnpm version.

Suggested change
nodejs 20.19.5
nodejs 20.19.5
pnpm 10.8.1

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "roo-code",
"packageManager": "[email protected]",
"engines": {
"node": "20.19.2"
"node": "20.19.5"
Copy link

@roomote roomote bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Consistency: Other repo files still pin Node 20.19.2 (e.g., .github/actions/setup-node-pnpm/action.yml default, packages/evals/scripts/setup.sh install/check, packages/evals/README.md). Consider updating these to 20.19.5 in this PR so CI/dev environments stay aligned.

Copy link

@roomote roomote bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Consider using a semver range for engines.node (e.g., ">=20.19.5 <21") to reduce churn and avoid blocking contributors on patch updates. Tooling (.nvmrc/.tool-versions) pins the concrete version for dev/CI, so this remains safe.

Copy link

@roomote roomote bot Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Consider using a semver range for engines.node (>=20.19.5 <21) instead of an exact pin. This avoids unnecessary churn with patch releases while still preventing breaking major upgrades. Align with .nvmrc/.tool-versions as needed.

Copy link

@roomote roomote bot Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Consider adding engines.pnpm to mirror packageManager and enforce pnpm compatibility. This helps prevent mismatched pnpm versions in environments that respect engines.

Suggested change
"node": "20.19.5"
"node": "20.19.5",
"pnpm": ">=10.8.1 <11"

},
"scripts": {
"preinstall": "node scripts/bootstrap.mjs",
Expand Down
2 changes: 1 addition & 1 deletion src/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
},
"engines": {
"vscode": "^1.84.0",
Copy link

@roomote roomote bot Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Avoid duplicating engines.node across root and src/package.json. VS Code extensions run on the extension host's Node bundled with VS Code; pinning engines.node here can block installs unnecessarily. Consider removing engines.node from src/package.json and rely on the root engines plus .nvmrc/.tool-versions for dev/CI pinning.

"node": "20.19.2"
"node": "20.19.5"
Copy link

@roomote roomote bot Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P3] Consider using a semver range for engines.node (e.g., ">=20.19.5 <21") to reduce churn and avoid blocking contributors on patch updates. Tooling in the repo (.nvmrc/.tool-versions) still pins a concrete version for dev/CI.

Suggested change
"node": "20.19.5"
"node": ">=20.19.5 <21"

Copy link

@roomote roomote bot Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P2] Mirror the semver range suggestion for engines.node here as well (>=20.19.5 <21) to keep developer environments consistent without forcing exact patch matching.

},
"author": {
"name": "Roo Code"
Expand Down
Loading