-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Make the default architect prompt create a todo list #5472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f169469 to
799d897
Compare
|
✅ No security or compliance issues detected. Reviewed everything up to 4f31a24. Security Overview
Detected Code Changes
Reply to this PR with |
|
✅ No security or compliance issues detected. Reviewed everything up to f16946947a32554a354a6854d7bf2a0b96d8f5ae. Security Overview
Detected Code Changes
Reply to this PR with |
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I noticed in the test case that when a promptComponent only has customInstructions but no roleDefinition, the mode ends up with an empty roleDefinition. Is this intentional? Would it make sense to merge partial promptComponents with the built-in mode defaults, so that missing fields (like roleDefinition) fall back to the built-in values rather than empty strings?
This updates the architect prompt and also fixes #5468
Important
Updates architect mode prompt to create a todo list, adds
isEmpty()utility, and enhancesgetPromptComponent()andgetModeSelection()functions with tests.update_todo_listtool instead of a detailed plan insystem-promptsnapshots.getPromptComponent()insystem.tsto filter out empty objects usingisEmpty().getModeSelection()inmodes.tsto merge prompt components with built-in modes.isEmpty()inobject.tsto check if an object is empty.getPromptComponent()inget-prompt-component.spec.ts.isEmpty()inobject.spec.ts.getModeSelection()with empty prompt components inmodes-empty-prompt-component.spec.ts.This description was created by
for 4f31a24. You can customize this summary. It will automatically update as commits are pushed.