Skip to content

Conversation

@roomote
Copy link
Collaborator

@roomote roomote commented Jul 8, 2025

Summary

This PR adds comprehensive patterns to .gitattributes to mark all test snapshot files as linguist-generated=true, which will exclude them from GitHub's language statistics.

Changes

  • Added patterns to cover common snapshot directory naming conventions:
    • /snapshots/ (Vitest/Jest standard)
    • /snapshots/ (alternative naming)
    • /.snapshots/ (hidden directories)
    • /_snapshots/ (underscore prefix)
  • Added patterns for snapshot file extensions:
    • *.snap (standard extension)
    • *.snapshot (alternative extension)

Impact

  • Current files affected: 27 existing snapshot files in src/core/prompts/tests/snapshots/
  • Future-proof: Automatically covers new snapshot files from testing frameworks
  • GitHub integration: Excludes generated test files from language statistics

Testing

  • Verified patterns match all existing snapshot files
  • All linting and type checks pass
  • No impact on actual source code files

Resolves the Slack request to mark snapshot files as linguist-generated=true.


Important

Marks test snapshot files as linguist-generated in .gitattributes to exclude them from GitHub language statistics.

  • Behavior:
    • Marks test snapshot files as linguist-generated in .gitattributes to exclude from GitHub language statistics.
    • Patterns added for directories: __snapshots__, snapshots, .snapshots, _snapshots.
    • Patterns added for file extensions: .snap, .snapshot.
  • Impact:
    • Affects 27 existing snapshot files in src/core/prompts/__tests__/__snapshots__/.
    • Future-proof for new snapshot files from testing frameworks.
  • Testing:
    • Verified patterns match all existing snapshot files.
    • No impact on source code files.

This description was created by Ellipsis for ada2f87. You can customize this summary. It will automatically update as commits are pushed.

- Add comprehensive patterns to .gitattributes to exclude test snapshot files from GitHub language statistics
- Covers __snapshots__, snapshots, .snapshots, _snapshots directories
- Includes .snap and .snapshot file extensions
- Affects 27 existing snapshot files in src/core/prompts/__tests__/__snapshots__/
- Future-proofs against new snapshot files from testing frameworks like Vitest and Jest

Resolves Slack request to mark snapshot files as linguist-generated=true
@delve-auditor
Copy link

delve-auditor bot commented Jul 8, 2025

No security or compliance issues detected. Reviewed everything up to efbf7d3.

Security Overview
  • 🔎 Scanned files: 1 changed file(s)
Detected Code Changes
Change Type Relevant files
Configuration changes ► .gitattributes
    Add linguist-generated attribute for snapshot files

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 8, 2025
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 8, 2025
@mrubens mrubens merged commit e9dca0a into main Jul 8, 2025
17 checks passed
@mrubens mrubens deleted the feature/mark-snapshot-files-linguist-generated branch July 8, 2025 19:33
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 8, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants