Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jul 8, 2025

Fixes an issue where connecting to Roo Code Cloud from the account tab was popping up a share modal


Important

Fixes issue where share modal was incorrectly shown from the account tab by ensuring it only opens when authentication is initiated from the share button.

  • Behavior:
    • Fixes issue where share modal was incorrectly shown when connecting to Roo Code Cloud from the account tab.
    • Introduces initiatedAuthFromThisButtonRef in ShareButton.tsx to track if authentication was initiated from the share button.
    • Share modal only opens if authentication is initiated from the share button.
  • Tests:
    • Updates TaskActions.spec.tsx to test that the share modal does not open when authentication is initiated from elsewhere.
    • Adds test to verify share modal opens when authentication is initiated from the share button.

This description was created by Ellipsis for 6b6c275. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners July 8, 2025 19:41
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jul 8, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 8, 2025

No security or compliance issues detected. Reviewed everything up to 6b6c275.

Security Overview
  • 🔎 Scanned files: 2 changed file(s)
Detected Code Changes
Change Type Relevant files
Bug Fix ► ShareButton.tsx
    Only show share modal when auth initiated from share button
► TaskActions.spec.tsx
    Update tests for share modal behavior
► .gitattributes
    Remove snapshot file configuration

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jul 8, 2025
@mrubens mrubens merged commit d116dbf into main Jul 8, 2025
24 of 25 checks passed
@mrubens mrubens deleted the fix_share_button_logic branch July 8, 2025 19:49
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jul 8, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants